commit 391b6ffb92d92f71483fb5386ce6fea15e1e2197 Author: Łukasz Wojniłowicz Date: Sun Nov 4 09:41:35 2018 +0100 Patch KService for AppImage, try 4 commit 6a23ef7bde9b9f8d842d38225efb2197809becc2 Author: Łukasz Wojniłowicz Date: Sun Nov 4 09:31:17 2018 +0100 Revert "Patch KService for AppImage, try 3" This reverts commit 9daccc1e839b08de474e4e2291bdd1179e68b360. commit 9daccc1e839b08de474e4e2291bdd1179e68b360 Author: Łukasz Wojniłowicz Date: Sun Nov 4 09:00:23 2018 +0100 Patch KService for AppImage, try 3 commit 0decd2bec75efddecfd47adbb10ca705fded7747 Author: Łukasz Wojniłowicz Date: Sat Nov 3 12:20:34 2018 +0100 Update AppImage dependencies commit 73d31fcde107b40db1f1422bdda497707456bacb Author: Thomas Baumgart Date: Sun Oct 28 10:19:21 2018 +0100 Avoid flooding of tables Delete old KVP records before writing new ones commit d6f6d57c919aaef3279215ab93f177c03968144f Author: Thomas Baumgart Date: Sun Oct 28 09:29:27 2018 +0100 Update the name of the OFX plugin to its new name Summary: Up to and including 4.8 the OFX importer plugin was called "KMyMoney OFX". From version 5 on it is called "ofximporter". So we update it here in case we find the 'old' name. This fixes the XML and SQL backend but I am sure it can be done in a more elegant fashion using SQL statements. Reviewers: ostroffjh Differential Revision: https://phabricator.kde.org/D15483 commit e4065a8997e13be4e08e1b681f3655e7eb07e202 Author: l10n daemon script Date: Sun Oct 28 06:59:15 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit cf0ead3cffecf7b70050dd52a09174881734329d Author: Thomas Baumgart Date: Fri Oct 26 17:05:34 2018 +0200 Fixed PostgreSQL access Regarding a user information on the forum (https://forum.kde.org/viewtopic.php?f=69&t=155429&p=406437#p406437), the default value needs to be enclosed in single quotes instead of double quotes for psql backends. I have checked that this change works with SQLite and MySQL as well. commit 4920511fa34f08dc04f70f42d01534248d1dc393 Author: l10n daemon script Date: Fri Oct 26 07:41:54 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit cdf3ff8dbb6e9e21f2b4422e955787602b23946b Author: l10n daemon script Date: Sun Oct 21 07:45:36 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit dbbc2bb3208eef3ad68500a2a9b0e46479e6e639 Author: Thomas Baumgart Date: Sat Oct 20 19:42:40 2018 +0200 Fixed style problems reported by cppcheck commit a45470125aea41290a0346b07f28bb9f778f5c71 Author: Thomas Baumgart Date: Tue Oct 16 20:53:02 2018 +0200 Set keyboard focus to first field on page entry The keyboard focus was not on the first field of a wizard page in the new user wizard when some pages were entered. This change sets the focus accordingly. commit 6197c14e92d4aefba11507f808050aa965b94149 Author: Thomas Baumgart Date: Tue Oct 16 20:52:01 2018 +0200 Don't show tip of day during first run commit 17808ac977bf2d686140e90733b7f62dae6e5064 Author: Thomas Baumgart Date: Sun Oct 14 10:34:05 2018 +0200 Hide splash screen when starting with an importable file On MS-Windows the splash screen is in the way in case the import opens a dialog. This change will hide the splash screen before the dialog will be opened. commit e53ee0804bc71d309e955ce39141c8adf8e22d5f Author: Thomas Baumgart Date: Sat Oct 13 18:34:47 2018 +0200 Simplify logical expressions in source code BUG: 385180 FIXED-IN: 5.0.2 commit b0c734f872c6d86e74a0b13c2aef27f089608d34 Author: Thomas Baumgart Date: Sat Oct 13 18:08:59 2018 +0200 Give anon.xml higher precedence than .xml The previous order of the filetypes caused .anon.xml be converted to .xml which causes the anonymization to fail. Also, there is no need to run the consistency check a second time. It is called by the application before the save operation is started regardless of the selected backend. commit 56cf4d5a2490c5decb497b3780c8f7bf1ac1e571 Author: Thomas Baumgart Date: Sat Oct 13 18:06:33 2018 +0200 Keep the relationship between investment and brokerage account Don't break the relationship between an investment account and its brokerage account when anonymizing the data. BUG: 340902 FIXED-IN: 5.0.2 commit c1a61bcfcff3821475b45bdda14526ebc2d0c392 Author: Thomas Baumgart Date: Sat Oct 13 18:04:41 2018 +0200 Create temporary file in the same directory Without providing the selected name as pattern for the temp file it will be created in a complete different area (/tmp on *nix systems). This change will create the temporary file in the same directory so that renaming it is an atomic operation. commit 98320a4ae5b78e778b4d069f3547daf68ee8ac7c Author: Thomas Baumgart Date: Sat Oct 13 14:01:50 2018 +0200 Revert "Output OFX scan results on console" This reverts commit d3ad33e3b5c6960683b8fd13f50258bc0c4186f5. commit bd829b19379773141071cf2b0d65277c6c48374f Author: Thomas Baumgart Date: Sat Oct 13 12:44:30 2018 +0200 Install missing header file The bug contains a patch for two files. Only half of it is still needed as the other mentioned file is already included. Thanks to Thorbjorn for spotting this. BUG: 392110 FIXED-IN: 5.0.2 commit 33a4bb71fde24f29e43977e3196192857b476a75 Author: Thomas Baumgart Date: Sat Oct 13 12:36:20 2018 +0200 Fix problem of detecting relative path leadin on ms windows In case a filename started with a drive letter on ms windows, an incorrect "./" was prepended causing the file not to be found. This change not only checks for the / as directory separator but also supports the \ variants and the drive letter variant on ms windows. commit d96f69b7c78a8ea012e8d87d88b96f26fd49949f Author: Thomas Baumgart Date: Sat Oct 13 06:35:54 2018 +0200 Use general multi statement summary report in QIF importer The QIF importer still used its own message to show a report. This has been changed to make use of the global available report mechanism. commit 9561996cdb0188bd7d8eba176ea45f1d7fac91cd Author: Thomas Baumgart Date: Fri Oct 12 16:28:50 2018 +0200 Fix QIF import file selection dialog When selecting a file to import the file selection screen defaults to "Import Files" and does not show ".QIF" files. It does show ".qif" files....lower case. As a result, user has to switch to "All Files" view. In addition, when navigating to the directory location of the file to import.....when importing another file.....the previous location is not remembered. User has to navigate to the location again. This change fixes the above mentioned problems. For existing user defined profiles, the filter may be amended to contain "*.qif *.QIF" to show lower and uppercase filenames using the QIF import plugin settings dialog. BUG: 399673 commit a3e124ea14de0a7e2751e0f6de6f4340598733ef Author: Thomas Baumgart Date: Thu Oct 11 20:52:50 2018 +0200 Fix saving to SQLite database Saving into an existing SQLite database was broken. This change allows to save into an existing database including the warning that the database already contains data which is overwritten. commit eec473d37a437a8e27596e16ab463727cc6484b6 Author: Thomas Baumgart Date: Sun Oct 7 20:37:50 2018 +0200 Fix empty price pair list In case the price list remained empty, a single entry was added that caused the program to fail. This has been fixed. commit 2bcb165ff6a2274565d230a55d237d9e974b86e9 Author: Thomas Baumgart Date: Sun Oct 7 20:36:33 2018 +0200 Add some more debug output to webconnect commit 85cc72af560bd8e17f82ea093658cc8f667a8986 Author: Thomas Baumgart Date: Sun Oct 7 11:19:19 2018 +0200 Don't crash if no file is opened In case no file is opened and the user clicks on the "Goto my financial summary page" link of the welcome page a crash happened. This change will show an informative message instead. commit de1d2f3ea34c7c31157c87ff7fc3ae899b8b840d Author: Thomas Baumgart Date: Sun Oct 7 11:07:45 2018 +0200 Removed unnecessary loading of welcome page There's no need to create the welcome page in the ctor when it will be created again during display. We can save some time here. commit 4e76fb9ddee5a10cd5cd82a7f456d6d6a01af01c Author: Thomas Baumgart Date: Sun Oct 7 11:06:00 2018 +0200 Updated localized startup screens to show KF5 commit 9479b16caefac4791784d3a1f15b344099816acf Author: Thomas Baumgart Date: Sun Oct 7 11:05:11 2018 +0200 Added tool to convert splash screens from svg to png This bash script converts the localized svg sources of the splashscreen to their png counterparts. commit fa2d82276d663b8e22442d0a3915f4ea129fe447 Author: Thomas Baumgart Date: Sun Oct 7 10:23:42 2018 +0200 Fixed name of Brazilian startup logo source file commit 0a0b0cfbd0adbdf6c88249f3020b4f984f3eda91 Author: Thomas Baumgart Date: Sat Oct 6 18:53:18 2018 +0200 Fix width of date edit widget Fix hidden digits from the date column when using the transaction form in the ledger view and longer short date format setup. This is copied from commit b565ce018e5f484e0bceb890992976a189f755b9 CCBUG: 396405 commit 84fe5ab427806614c233b60f4d65b187c538741b Author: Thomas Baumgart Date: Sat Oct 6 18:47:23 2018 +0200 Fix placement of calculator The calculator is placed in the middle of the screen when it is first opened after transaction edit started. If closed and re-opened in the same transaction edit session it is placed correctly. This change places the calculator always in the right position next to the amount edit widget. Fix taken from commit 6a221524755177087fb1dcd110af1bc5f592f61a CCBUG: 283784 commit 9373aeb22dd43a029f03a1fea24e702ae2034307 Author: Thomas Baumgart Date: Sat Oct 6 13:17:01 2018 +0200 Change order of includes to fit project standard commit 8bd3fe1ef9fc852eb6c3084ece848734d3363756 Author: Thomas Baumgart Date: Sat Oct 6 12:47:26 2018 +0200 Close splash screen on windows The splash screen does not disappear automatically on ms-windows if another dialog such as the new file wizard is active. Nevertheless, the splash screen stays on top of all windows. To avoid this, we simply close it directly before opening the new file wizard at first time run. commit 1784b2c380ec8e8a434a13751b698c14b59af744 Author: Thomas Baumgart Date: Sat Oct 6 09:16:01 2018 +0200 Support field name change in databases In some instances, fields were renamed from one DB layout version to the next. This caused KMyMoney to crash as it still used the old name. This change introduces a method to support these field name changes. commit 15c9f3ac39c8719095ee9aaa66097d1bd191380b Author: Thomas Baumgart Date: Fri Oct 5 17:02:24 2018 +0200 Fix problem with leading slash in filenames under ms-windows A URL of the form file:///C:/abc.xyz is returned as /C:/abc.xyz when the path() method is used. This causes the QFile::open() method to fail. The QUrl::toLocalFile() method does return C:/abc.xyz in this case. BUG: 395980 BUG: 399378 commit b8e58e8126262970aeb25314e919c1d5ce53a940 Author: Thomas Baumgart Date: Thu Oct 4 13:43:07 2018 +0200 Fix indentation commit 36aa7fae7db67beae356ac93ade863716375173c Author: Thomas Baumgart Date: Wed Oct 3 11:38:07 2018 +0200 Add trace message when OFX file open failed for import commit f38af73426f24b630a953ad56568dd27c814f705 Author: Thomas Baumgart Date: Tue Oct 2 21:17:34 2018 +0200 Fix balance chart view On one of my accounts the balance chart view did not show the graph as expected. This fixes the problem. commit 99dd884755864416138a44f8cda645ea61605ee8 Author: Thomas Baumgart Date: Tue Oct 2 18:51:44 2018 +0200 Make sure actions have the right state In case the ledger view was the last view selected and KMyMoney starts with the option to select the last view at startup, the 'show balance chart' action was disabled. This change allows to a view to setup the actions upon selection. commit d3ad33e3b5c6960683b8fd13f50258bc0c4186f5 Author: Thomas Baumgart Date: Tue Oct 2 10:20:11 2018 +0200 Output OFX scan results on console commit 62d82226bfc45a209290a4dd5c495fd2a7b729f4 Author: Thomas Baumgart Date: Mon Oct 1 19:15:24 2018 +0200 Fix build on FreeBSD commit 8c8b53a9c40f925295a7030dabe3773a747f2f50 Author: Thomas Baumgart Date: Mon Oct 1 17:15:47 2018 +0200 Fix reading splits of scheduled transactions from DB The dates were not extracted properly. commit eadf947e704415b628d48062b39710cf9e1af29f Author: Thomas Baumgart Date: Mon Oct 1 17:00:49 2018 +0200 Add feature to make DB password visible during input Code based on plasma-nm passwordfield commit 73dc6c0e163c3f5ce34b54595bdf1e989f14ff21 Author: Thomas Baumgart Date: Sun Sep 30 22:55:24 2018 +0200 Prevent crash during webconnect import using firefox Calling the eventloop during the emission of a signal emitted by a QTcpSocket causes problems. The fix is to call the receiver with all the processing and dialog logic from within the eventloop itself using a delayed call. BUG: 396831 FIXED-IN: 5.0.2 commit f7602b3540a1518e82ec311f23313958f4cb5cb7 Author: Thomas Baumgart Date: Sun Sep 30 19:20:07 2018 +0200 Don't use default for text field in MySQL DB during table creation From the MySQL documentation: BLOB and TEXT columns cannot have DEFAULT values. CCBUG: 398410 commit e9d040d09765945eed73ebe6ede1a313a407dfe5 Author: Thomas Baumgart Date: Sun Sep 30 17:49:22 2018 +0200 Reset current selected account when loading a file The ID of the currently shown account in the ledger view was not reset when another file was loaded. This false information was then used while editing transactions ending in an error message, that the account is unknown. BUG: 399244 FIXED-IN: 5.0.2 commit 96045daafb56188b72e8930ae17ff6c3f60ff245 Author: Thomas Baumgart Date: Sun Sep 30 15:56:31 2018 +0200 Scan for gnupg home dir location Scan for the secret keyring file by traversing the home directory and the application data directories known to QStandardPaths and some know subdirectory combinations. CCBUG: 399230 commit 7d30bb0f4792d840eaed86ff1e2043026bd4db7e Author: Thomas Baumgart Date: Sun Sep 30 13:57:19 2018 +0200 Fix QWebEngine on Qt 5.11 This patch fixes blank pages when QWebEngine is used. (cherry picked from commit 5512296d660eab013d65566ec78307042e98c739) commit cfd83c18c82602c2d6caeb21f9d90fc71840e73a Author: Thomas Baumgart Date: Fri Sep 28 21:04:23 2018 +0200 Fix tags Loading the color did not work from databases Cleaned up code commit 9a53edcb4aa3fd2de1729fe9a9a6cde2e6af3260 Author: Thomas Baumgart Date: Fri Sep 28 18:55:48 2018 +0200 Fix reading tag information from XML based files Also added unit test case commit 074767a3f4b0bdc073a2a8281ec16af07f9b5128 Author: Thomas Baumgart Date: Fri Sep 28 18:06:22 2018 +0200 Avoid using QStringBuilder commit 1e68d19ec5de4873dea25065e469f1a3e1cf2fb8 Author: Thomas Baumgart Date: Fri Sep 28 18:05:46 2018 +0200 Implement reading prices from database This was still missing and did not work at all commit 05c9370b809afc8175ca9e4c79e6119f05d1d43d Author: Thomas Baumgart Date: Mon Sep 24 08:54:18 2018 +0200 Fix problem reported by scripty The warning reported was Warning: ./kmymoney/plugins/kbanking/kbanking_debug.rc does not have a recognised first line and texts won't be extracted Since this file only contains some debug support stuff, we don't need the extraction. At the same time, I renamed the input file so that it is clear that is processed through cmake's macro expansion. commit 5c8cbc29a0807bd0dd76c8b5e22411a098ee12d8 Author: Thomas Baumgart Date: Sat Sep 22 20:30:04 2018 +0200 Fix the start with last selected view feature Closing the file switches to the home view and that was stored last so the feature was not working properly. This has now been fixed by not storing the view change when no file/db is opened. Also, the switch to the default view is postponed until the event loop is running. Otherwise, the view was not displayed properly. CCBUG: 398957 FIXED-IN: 5.0.2 commit cc670b1a8733ab3f2b4c5640122d661390575c76 Author: Ralf Habacker Date: Thu Sep 20 22:09:38 2018 +0200 Add test for MyMoneyTransactionFilter This test was created to check the basic functions of the transaction filter, but does not claim to be complete. It was written by me for 4.8 and ported from Thomas Baumgart to KF5. CCBUG:395327 Test Plan: compiled and tested on linux Reviewers: wojnilowicz Signed-off-by: Ralf Habacker Differential Revision: https://phabricator.kde.org/D15107 commit c56f154699f258b7519902b07bf73f80eb390914 Author: Thomas Baumgart Date: Thu Sep 13 09:13:37 2018 +0200 Remove reference to online balance when unmapping account In case the online mapping for an account is removed, the last online statement balance was still shown and became invalid over time. This change removes the last known statement balance from the data when unmapping an account. commit ac602ffdb0297706f1f39602856bbe20225e906c Author: Thomas Baumgart Date: Mon Sep 10 21:47:49 2018 +0200 Ask for password when connecting to database BUG: 398409 BUG: 394384 FIXED-IN: 5.0.2 commit 96f130f343661058b9b57256743a562db0f09491 Author: Thomas Baumgart Date: Sat Sep 8 23:02:21 2018 +0200 Check for schedules when file is loaded/opened commit f485c8f6327b5303cc64186b46c52e9db3481078 Author: Thomas Baumgart Date: Sat Sep 8 18:40:58 2018 +0200 Fix information reports All information reports were completely broken. This change brings back their functionality. BUG: 398394 FIXED-IN: 5.0.2 commit 93a87bc816bba1a5c09642981d4a0b3cab6b873b Author: Thomas Baumgart Date: Sat Sep 8 12:08:02 2018 +0200 Fix appending of file extension on export Only append the necessary file extension when the focus leaves the field and not on every key pressure. Harmonize behavior of CSV and QIF exporter. BUG: 395985 FIXED-IN: 5.0.2 commit 7bee26d66918d2ebd6350dd54866ce34a2b7ddda Author: l10n daemon script Date: Sat Sep 8 08:14:34 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 5c590ebd11d176fd0a33c4c6f6d613ba7c99d340 Author: Thomas Baumgart Date: Fri Sep 7 19:39:14 2018 +0200 Disable another label commit 90c714c693edb88467fe70dcd97277a18dc8e47b Author: Thomas Baumgart Date: Fri Sep 7 19:27:25 2018 +0200 Fix Bi-Monthly, Quarterly or Yearly budget reports BUG: 393752 FIXED-IN: 5.0.2 commit d28f3603112f184309613d0d7b66e250cfc5448c Author: Thomas Baumgart Date: Fri Sep 7 19:21:22 2018 +0200 Disable label if field is not accessible commit 62919efeabcd12f81f83946183c0384237840d04 Author: l10n daemon script Date: Fri Sep 7 07:56:15 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 7b6e1429ff3fbc869d3872cd7096548097402795 Author: l10n daemon script Date: Thu Sep 6 07:52:31 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 98976cfdb18cdc77f155f605188d592df3e71d9b Author: Thomas Baumgart Date: Wed Sep 5 19:50:13 2018 +0200 Bring back shortcut category entry feature BUG: 395459 FIXED-IN: 5.0.2 commit 9a6cc89e9a5ef03409b28f6967caabe8efadda4f Author: l10n daemon script Date: Wed Sep 5 07:50:51 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 15536551eaed3e4db13f9cd4103ec5a0e0ac4d42 Author: Thomas Baumgart Date: Tue Sep 4 19:37:04 2018 +0200 Fix Windows builds This change amends commit 86b53d2b398 and is needed for Windows builds. commit 5eaf96d6cb79c76ad7eb5c412c1c8597579827fe Author: Thomas Baumgart Date: Tue Sep 4 15:40:04 2018 +0200 Use three day overlap in case of OFX d/l based on last statement date In case the OFX online transaction download is based on the date of the last statement date, then subtract three days from it just like in the HBCI interface. This allows to catch some late entries made by the institution after the last download was performed. commit 423ef4e1e512cce86a1e815eeadcd0728e7a250b Author: l10n daemon script Date: Tue Sep 4 07:56:32 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 8f3f707a76e69c82a5c657da22443ba34fc5caa9 Author: Thomas Baumgart Date: Mon Sep 3 20:16:23 2018 +0200 Write cli trace message when libofx returns commit 4a3a2e7516dd785be938a1ac3f567e225c0aa5fa Author: Thomas Baumgart Date: Mon Sep 3 20:15:37 2018 +0200 Turn off libofx position output commit 86b53d2b398725883366680c454dec20bcdbbdee Author: Thomas Baumgart Date: Mon Sep 3 08:17:39 2018 +0200 Work-around for missing statement end date This change amends commit 3e95b8c4ec4b6. Some XML elements of an OFX file/download are not processed by LibOFX. Among them is the statement date information for investment statements. This adds a work-around which uses the post date of the youngest transaction as the statement end date should the real thing be missing. BUG: 343878 FIXED-IN: 5.0.2 commit 42b6f804c5ea92d29e873f78cd4dfaa5ed39cdca Author: l10n daemon script Date: Mon Sep 3 07:44:00 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit a89835190a28f0d6226ae99d716620492aa2949b Author: l10n daemon script Date: Mon Sep 3 06:36:37 2018 +0200 GIT_SILENT made messages (after extraction) commit a8949682c2f3dd85f956318f6f5f86da3819c933 Author: Thomas Baumgart Date: Sun Sep 2 20:32:37 2018 +0200 Fix MyMoneyFile::isTransfer Commit c224b2cf reverted the logic of this method so that parts of the application did not work properly anymore. This change brings back the original behavior. BUG: 396987 FIXED-IN: 5.0.2 commit 10f0d466ac782174593eee235de5b6e686dbd124 Author: Thomas Baumgart Date: Sun Sep 2 19:59:37 2018 +0200 Fixed a typo in a comment commit 18c3dc393c0de8326ede02d0402f6cbca8c9c7e2 Author: Thomas Baumgart Date: Sun Sep 2 19:58:58 2018 +0200 Bring back import summary for file import commit bd270e886bc5d58cf832fc6c8604f8e5df517a02 Author: Thomas Baumgart Date: Sun Sep 2 15:12:58 2018 +0200 Added part lost during recent merge This was lost during the merge in 169deedaa1b7 commit 84fe8e7c72a3f40cb17b7b92807cb695a9904b31 Author: Thomas Baumgart Date: Sun Sep 2 14:57:42 2018 +0200 Make sure data fields are not exceeded commit 169deedaa1b75f06ee177aaa0e7422e8f7aa23c3 Merge: f749c3fa 8c0e03e1 Author: Thomas Baumgart Date: Sun Sep 2 14:25:57 2018 +0200 Merge remote-tracking branch 'origin/master' into 5.0 commit 8c0e03e1051edeb601e1507d28b70c28be9e704b Author: Thomas Baumgart Date: Sun Sep 2 09:30:45 2018 +0200 Revert "Don't require fees for reinvest dividend action" This reverts commit 7f6ce06ab35a4438e57d09063ddbe2bc575f02e9 and adjusts to intermediate changes and makes the fees an optional item. BUG: 390750 FIXED-IN: 5.0.2 commit 3523f662d8107c10192e67a6c0765aea825234a1 Author: Łukasz Wojniłowicz Date: Sat Sep 1 08:59:05 2018 +0200 Temporarily diasable gwenhywfar for AppImage commit ae06041fb921122489085a3bc6cdf0b22b4da28c Author: Łukasz Wojniłowicz Date: Fri Aug 31 09:08:28 2018 +0200 Revert "Lessen required GCC version" This reverts commit 64d17ec75212d7d75d3c2ca3719a7e6750d9ebb4. commit 433bc7252d205524705fb2f829e1ade950b236f0 Author: Łukasz Wojniłowicz Date: Thu Aug 30 22:18:52 2018 +0200 Add more AppImage dependencies commit 9855021cc77aa401252172fe3615833b1e9d97ec Author: Łukasz Wojniłowicz Date: Thu Aug 30 14:15:54 2018 +0200 Use WebEngine for AppImage commit d2e0bf1fa526edb8218d336440c9885f51e7cf6b Author: Łukasz Wojniłowicz Date: Thu Aug 30 12:32:50 2018 +0200 Fix building dependencies for AppImage commit 65b0d0677d94dcea3fa8d60a85ea85edf6a43ad0 Author: Łukasz Wojniłowicz Date: Thu Aug 30 10:42:21 2018 +0200 Move ext_kglobalaccel before it's required commit 39dc8092069bbcf4e98a2fa00fc1e0a3cc1aae5b Author: Łukasz Wojniłowicz Date: Wed Aug 29 16:28:06 2018 +0200 Add ext_kglobalaccel dependency to kxmlgui commit 503942b900ab3f50391c16f789a3e89dafde735f Author: Łukasz Wojniłowicz Date: Tue Aug 28 17:37:22 2018 +0200 kdbusaddons doesn't need any patch commit 64d17ec75212d7d75d3c2ca3719a7e6750d9ebb4 Author: Łukasz Wojniłowicz Date: Mon Aug 27 20:50:48 2018 +0200 Lessen required GCC version The last version of GCC known not to work is 5.3.1 so I assume that GCC 5.4 works. commit 99ecc6af3cb1ceb3b51e0618facaf46be14b0461 Author: Ralf Habacker Date: Mon Aug 27 19:52:00 2018 +0200 Add fatal warning in case unsupport gcc version has been used Reviewed By: tbaumgart Differential Revision: https://phabricator.kde.org/D13838 commit 0503358d0d128d9ebf9a4eb6d7c29bd8207dcc88 Author: Łukasz Wojniłowicz Date: Mon Aug 27 16:10:26 2018 +0200 Add Phonon4Qt5 to AppImage dependencies commit 14760ff8a671f61e6a5e053d119912430ac94cf8 Author: Thomas Baumgart Date: Sun Aug 26 16:04:31 2018 +0200 Speedup loading of home page Whenever an account entry was shown on the home page, the application iterated twice over all transactions to collect some statistics information. The relevant information is now collected once which improves performance drastically. commit 23a56f006bddfe14837c7bf249e7d43b9e58eecf Author: Łukasz Wojniłowicz Date: Sun Aug 26 13:27:52 2018 +0200 Build KDE Frameworks for AppImage commit 3d5b52c1e404a1d0db69312c964f8e6b30894bd5 Author: Łukasz Wojniłowicz Date: Sun Aug 26 12:31:10 2018 +0200 Try to fix SQLCipher test on MSVC commit 162f7542a09d57d2a4adac76b357baa30e3aad3b Author: Łukasz Wojniłowicz Date: Sun Aug 26 09:48:40 2018 +0200 Don't hardcode custom icons location Custom icons aren't visible on MS Windows because path to them is set to install directory. It happens to be that this install directory isn't the directory where KMyMoney searches for icons on MS Windows. This patch intends to search for the icons before it adds them to icons search path. It's untested though. Differential Revision: https://phabricator.kde.org/D15087 commit 567162a3f240660a0454306e465332b9651616c8 Author: Łukasz Wojniłowicz Date: Sun Aug 26 07:21:10 2018 +0200 Don't build that many dependencies for AppImage commit 77e17a602d93dba50c475a93ce5798677affbb94 Author: l10n daemon script Date: Sun Aug 26 05:37:02 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 6c1c447eeffa88087bc39b3a5abe72104c53ff3f Author: Łukasz Wojniłowicz Date: Sat Aug 25 19:30:34 2018 +0200 Fix some scripts for AppImage commit 5b0e08c895a4978f10bf3de7b1de52df0d60c655 Author: Thomas Baumgart Date: Sat Aug 25 10:21:28 2018 +0200 Removed some unused variables commit 50cdf658c08523acb063ad3aab2ff00a2988b18a Author: Thomas Baumgart Date: Sat Aug 25 09:42:31 2018 +0200 Fix testcase The last commit requires the security IDs to start out with the letter 'E'. This needed to be adjusted in the testcase. commit 419c2df34b631baa458f13facf7ffce89ed9b511 Author: Thomas Baumgart Date: Sat Aug 25 07:49:07 2018 +0200 Improve determination of highest used id Object IDs in KMyMoney are usually constructed by a letter based lead-in followed by a numeric value. Adding objects with a different ID layout could cause trouble when they still contain some numeric values. The change only takes those IDs into account when determining the highest used number that follow the above mentioned layout of KMyMoney. BUG: 397824 FIXED-IN: 5.0.2 commit c7422200f73cc0196b5cc9a15c1179cd3a8284ee Author: Łukasz Wojniłowicz Date: Sat Aug 25 07:09:06 2018 +0200 Patch libxml to link against iconv commit 5d6fb733ded69a5dcd4b1aaa1f77ac9e36e5b02c Author: Thomas Baumgart Date: Fri Aug 24 18:45:26 2018 +0200 Remove unnecessary include commit 3e95b8c4ec4b640c83ce36d0623f1bdc8ca2d136 Author: Thomas Baumgart Date: Fri Aug 24 18:09:51 2018 +0200 Store date independant from statement balance Store the date of the last imported independant of a changed statement balance. BUG: 343878 FIXED-IN: 5.0.2 commit 8a7c95bb4928c694eff9bc37b1e26b577948f481 Author: Łukasz Wojniłowicz Date: Fri Aug 24 17:18:42 2018 +0200 Don't build libxml2 without environment variable commit b4aba75c5bdec812d8824f9d31cc14d9a7c7d8ba Author: Łukasz Wojniłowicz Date: Thu Aug 23 17:42:30 2018 +0200 Try to fix building of libxml2 commit 63b4cb86d5529b81b8a247adc621959990c7b7d6 Author: Łukasz Wojniłowicz Date: Wed Aug 22 16:52:03 2018 +0200 Try to fix building on MinGW commit b6c694e8376895d962d01b5c2224776b720e98df Author: Łukasz Wojniłowicz Date: Wed Aug 22 15:46:35 2018 +0200 Try to fix building of libxml2 commit c052378f92f3bb952b3249966b709f4bb22c88bd Author: Łukasz Wojniłowicz Date: Wed Aug 22 14:25:47 2018 +0200 Try to fix building on MinGW commit 2bb6e4ae5ee56cd460a48873ea9c75bb26117dcc Author: Ben Cooksley Date: Wed Aug 22 03:48:19 2018 +1200 Make these scripts executable so the Binary Factory can use them commit a1a110e59dd6230fd6613b30b57d01ca83efcd25 Author: Thomas Baumgart Date: Tue Aug 21 14:16:06 2018 +0200 Improve display of line graphs showing a horizontal line When the whole line graph consisted of a horizontal line then the Y range of the chart was not correctly calculated. This fix takes care of the scenario by artificially extending the Y range resulting in a readable graph. BUG: 397436 FIXED-IN: 5.0.2 commit 79769249df532eeb5534975aba4cfd9fe0eca0ea Author: Łukasz Wojniłowicz Date: Sun Aug 19 15:35:15 2018 +0200 Try to fix building on MinGW commit 7e0d6cb56644a30e0593cef558f3ea9c5a49dd14 Author: Łukasz Wojniłowicz Date: Sun Aug 19 09:14:35 2018 +0200 Add AppImage build scripts Based on Krita's work. It's intended to run in Binary Factory just like Krita's AppImage https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/ Differential Revision: https://phabricator.kde.org/D14926 commit 2e00772dd8c21e27dd238dba348159a0e3b6fd34 Author: Yuri Chornoivan Date: Sun Aug 19 09:02:22 2018 +0300 Fix minor typo Signed-off-by: Yuri Chornoivan commit 20c1d93863281cd4a84a9b86e8ddcbc73afc187e Author: Thomas Baumgart Date: Sat Aug 18 21:01:42 2018 +0200 Keep linebreaks in memo of AqBanking transaction imports When retrieving all new transactions in KMyMoney for one bank account connected via AQHBCI, all the lines in the description are appended into a single string. This change adds an option to keep separate lines on a per account basis. commit cadea778eadd5fcf1552271a04e099fb084c4f60 Author: Thomas Baumgart Date: Sat Aug 18 10:30:35 2018 +0200 Fix odd behavior of double-click in register part II Improve commit b777b3b9cd28d556f52a2712186f41605b1e17b6 such that the odd behavior is also fixed in case the warning dialog is closed without editing the transaction (Cancel is pressed). BUG: 397457 commit f749c3faa209ef447086ecbbeb1da6ccdff58338 Author: l10n daemon script Date: Sat Aug 18 06:24:12 2018 +0200 GIT_SILENT made messages (after extraction) commit ae87f445c4ea2d2e37e56f99a8891cd3c8bb56ec Author: l10n daemon script Date: Sat Aug 18 03:42:30 2018 +0200 GIT_SILENT made messages (after extraction) commit b777b3b9cd28d556f52a2712186f41605b1e17b6 Author: Thomas Baumgart Date: Fri Aug 17 21:06:25 2018 +0200 Fix odd behavior of double-click in register If a user is viewing the ledger, and a transaction is selected (such as if it was just edited it) and then a double click is performed on another transaction, it edits the previously selected transaction but not the one that was clicked on. This only happens if the first transaction is reconciled and a dialog pops up before the transaction is edited. This change fixes the behavior. BUG: 397457 FIXED-IN: 5.0.2 commit b5f4f4a2fd5581c1c254ad717b34e36cfce8efc5 Author: l10n daemon script Date: Sun Aug 12 05:43:03 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit e106fe4b9fc9f0d6c9afb6636bdeb84d5ebdadfa Author: Thomas Baumgart Date: Tue Aug 7 13:13:13 2018 +0200 Resolve krazy warnings Resolve some reported problems either by fixing the issue or in case of a false positive by excluding the check commit 72918e96f6fcb0b9d0ecd51747e4cb0987dbfd96 Author: Łukasz Wojniłowicz Date: Thu Aug 2 18:45:28 2018 +0200 Depluginize SQL storage helpers It gets rid of three one-method plugins. I see no point in making plugin of something that's mandatory to save a file with user data. Besides it save us time on loading these plugins and makes code shorter by getting rid of whole plugin handling stuff. Differential Revision: https://phabricator.kde.org/D14564 commit 3467b9ef9c834545aebb4d7fc677b5b1c7ff40d9 Author: Thomas Baumgart Date: Sun Aug 5 20:21:06 2018 +0200 Don't include opening transactions twice The updated testcase showed another problem. Since the opening balance transaction is now already included in column 0 we must avoid to add it a second time while processing the transactions. commit c9b48b698d826e5104d993e34862bf9b3da345d7 Author: Thomas Baumgart Date: Sun Aug 5 20:19:43 2018 +0200 Update test case to match last change The last commit requires to update the test case since the first element is now filled with the opening balance instead of zero. commit d5210daac1f89d84cbf56d23860e064ad90cbabf Author: Thomas Baumgart Date: Sun Aug 5 15:29:42 2018 +0200 Fix y-offset of graph for all dates Summary: The left most value in a networth graph (called the opening balance) is calculated based on the closing balance of the date prior to the selected start date. This is perfectly OK but leads to the logical consequence that if the user selects "all dates" as the date range this value will be zero. Since the opening balance is the first transaction it would make sense to use the opening balance if the above is the case. This way, the graph starts out at the level of the sum of included opening balances and not zero, which avoids an initial edge to be displayed. This change does exactly that and solves the problem. BUG: 397020 Test Plan: Use the same data used to generate [[ https://bugsfiles.kde.org/attachment.cgi?id=114236 | the graph attached to the bug ]] and verify that the edge on the left is not painted anymore. Reviewers: antoine Reviewed By: antoine Differential Revision: https://phabricator.kde.org/D14624 commit ca5c4d62eba710cbc7f7ec3d12ecac84fd15e4ee Author: Thomas Baumgart Date: Sun Aug 5 12:27:30 2018 +0200 Use standard colors with better readability Summary: The background colors used for imported and matched transactions is not readable. This change sets the colors to be more readable. To further differentiate between Imported and Matched transactions, the matched transactions are now using bold text. BUG: 397023 The first row shows a matched transaction, the second row an imported one prior to change it looks like this: {F6176182} after the change it looks like this {F6176190} Reviewers: antoine Reviewed By: antoine Subscribers: antoine Differential Revision: https://phabricator.kde.org/D14623 commit 7ec79d01a3c3ae2ab7fa2656c3b289e948415c37 Author: Łukasz Wojniłowicz Date: Thu Aug 2 20:20:21 2018 +0200 Fix bug with unknown QSqlQuery field name GETDATE macro already requests a value from query, so providing query value to it is wrong and causes warning like this QSqlQuery::value: unknown field name '2018-06-09' commit f8aa2d392b70b4fb79f347af10bdf81c4a74913a Author: Łukasz Wojniłowicz Date: Wed Aug 1 18:58:24 2018 +0200 Move payee identifier widgets to kmm_widgets Patch moves IBAN/BIC and national account number widgets from loadable to shareable, together with StyledItemDelegateForwarder which indirectly uses it. This makes payee identifier loader redundant and thus may allow to compile without --allow-multiple-definition linker option. Redundant code will be removed after this patch gets accepted. Differential Revision: https://phabricator.kde.org/D14540 commit 2a08b64b71f6290df7483d1213b37e436f004a58 Author: Thomas Baumgart Date: Fri Aug 3 19:09:25 2018 +0200 Fix oddity with closed accounts One could close a mapped account or could map a closed account. This does not make sense and has therefore been disabled. commit abebe72730b1065a3e443528c610a36fd6174a6a Author: Thomas Baumgart Date: Wed Aug 1 21:30:56 2018 +0200 Fix total networth and profit display The total value display on the accounts, categories and institutions view was broken due to one of the recent changes. This change brings back the function. BUG: 397021 commit 5dc80e8fca0685e6d70400294bee99e979f19f86 Author: Thomas Baumgart Date: Mon Jul 30 18:59:24 2018 +0200 Support more than one online banking provider during update The online accounts need to be updated per provider as some queue the requests and process them at once. Having mixed providers in this case causes the update to fail for some accounts. commit 4b9cc6a8016ccacf501cf41d8d9978436926e6fa Author: Thomas Baumgart Date: Mon Jul 30 18:57:48 2018 +0200 Remove per account statement summary The OFX importer displayed a summary per account which conflicts with the global summary after all accounts have been updated and is very annoying in case you have many accounts. BUG: 396886 commit d1a09f075a3df275c3b6d2cccfd3d4e48790992f Author: Joshua Christopher Date: Mon Jul 30 08:26:09 2018 +0200 Updated screen shots in user documentation for KMyMoney 5.0.1 Summary: Took new screenshots for the user documentation that shows the look and feel of KMyMoney 5.0.1 on KDE 5.13 with the KDE Breeze style. Reviewers: ostroffjh, #kmymoney Reviewed By: ostroffjh Subscribers: tbaumgart, ostroffjh Differential Revision: https://phabricator.kde.org/D13994 commit 6d444fcdb2cd5408c382d0a97d7a3f17abc9505b Author: Łukasz Wojniłowicz Date: Sun Jul 29 17:16:51 2018 +0200 Move payee identifier reading and writing to XML storage Differential Revision: https://phabricator.kde.org/D14462 commit b846d7d11c9f76f1b2be9bb2ff4bf4a6c8d42f35 Author: Thomas Baumgart Date: Sun Jul 29 19:04:48 2018 +0200 Added authorship to recently changed files commit 033b747aa5184b29dd846d1573ce87a0cd6bffab Author: Thomas Baumgart Date: Sun Jul 29 18:55:05 2018 +0200 Improve CSV importer Summary: - Make the CSV importer to run as a modal dialog of the application as other importers do. This avoids a whole bunch of problems. - Combine the Finish and Import button into a single "Import CSV" button on the last page of the wizard. - In case 'Skip setup' is marked on the first page, the wizard stops on the last page and does not automatically start importing. BUG: 396759 Test Plan: Tested single file import and web-connect import Reviewers: wojnilowicz Reviewed By: wojnilowicz Differential Revision: https://phabricator.kde.org/D14459 commit 5ec93f9f59109a576fc4b0c3913f02a03d1cc46b Author: Thomas Baumgart Date: Sun Jul 29 11:28:48 2018 +0200 Fix usage of QToolButton Resolve concern raised in https://phabricator.kde.org/R261:e5c713da9e6f commit 174d75d09644470b98b27101d92945cb4e7f3b32 Author: Łukasz Wojniłowicz Date: Sun Jul 29 11:04:32 2018 +0200 Fix build of tests on MSVC commit efe1f5d74ff750496a30751ddbce9aa239519b59 Author: Łukasz Wojniłowicz Date: Sun Jul 29 09:51:39 2018 +0200 Try to fix MyMoneyException on MS Windows commit 96568162bd58b7e77272e53aa37cb523f07a36ca Author: Łukasz Wojniłowicz Date: Sun Jul 29 09:26:14 2018 +0200 Try to fix MyMoneyException on MS Windows Should fix mymoneyexception.h(56): warning C4275: non dll-interface class 'std::runtime_error' used as base for dll-interface class 'MyMoneyException' on MSVC commit e5c713da9e6f3bbcc3a1694d9f7753be2dfe8070 Author: Thomas Baumgart Date: Sun Jul 29 08:05:12 2018 +0200 Fix issues reported by Krazy commit be12954894260d0a3945627cc037953ee24e8382 Author: Łukasz Wojniłowicz Date: Sun Jul 29 07:48:40 2018 +0200 Try to fix SQLCipher on macOS commit 07795254df17fe1cc4999ecff51f37cac3da40f3 Author: Łukasz Wojniłowicz Date: Sun Jul 29 07:47:32 2018 +0200 Try to fix exception handling on FreeBSD commit e4bed74334939c9bc9bc3f83cfb25f3841b754a9 Author: Łukasz Wojniłowicz Date: Sun Jul 29 07:46:27 2018 +0200 Fix copying of TestMyMoneyObject TestMyMoneyObject has d-pointer which hasn't been copied properly when constructed TestMyMoneyObject has been returned from readBaseXML. commit d9e1b377fa82874174fdb3aab7fb8f874afc0db3 Author: Łukasz Wojniłowicz Date: Sun Jul 29 07:43:23 2018 +0200 Break scheduled transactions properly on MS Windows Previously "Scheduled\nTransactions" didn't break in place of "\n" showing some garbled characters. commit b22945af085fffc53dfc3ad072da8ac4f52303e5 Author: Łukasz Wojniłowicz Date: Sun Jul 29 07:42:39 2018 +0200 Disable warnings for SQLite external files These files aren't our code and should be treated as any other external code. commit 7b344a4e2289ddde175a8ef42685b2f2def11e61 Author: Thomas Baumgart Date: Sun Jul 29 07:23:56 2018 +0200 Cleanup comments GIT_SILENT commit 66523b3c99812e30816668351504063d6620a9c6 Author: Thomas Baumgart Date: Sun Jul 29 06:52:16 2018 +0200 Only show a single summary of statement import Summary: Depending on the number of statements imported via online connects to banks, the sheer number of dialogs popping up is annoying and time consuming. This change reduces this to a single dialog which is also shown if no transaction has been imported at all to notify the termination of the process to the user. BUG: 396886 Test Plan: I ran updates for single accounts as well as multiple accounts Reviewers: wojnilowicz Reviewed By: wojnilowicz Differential Revision: https://phabricator.kde.org/D14439 commit 5e7813dba660ca904d19d308d55a0df330bf0693 Author: Thomas Baumgart Date: Sat Jul 28 16:51:40 2018 +0200 Remove the usage of lastStatementDate in account KVP Summary: Very old versions of KMyMoney used to store the reconciliation date in the KVP as "lastStatementDate". Since we don't use it anymore, we get rid of the references. Fixes T9254 Test Plan: Ran adjusted testcases Reviewers: wojnilowicz Reviewed By: wojnilowicz Maniphest Tasks: T9254 Differential Revision: https://phabricator.kde.org/D14441 commit 0938c60483b988df80015408f8ee9bf5bc626ed3 Author: Łukasz Wojniłowicz Date: Fri Jul 27 19:41:25 2018 +0200 Try to fix QSQLCipher on MinGW commit bfb370ae34691739bb2f1ef5408720d99eee2b70 Author: Thomas Baumgart Date: Fri Jul 27 14:06:05 2018 +0200 Adjust price regex to be KMyMoney 5 and thousand separator save CCBUG:396797 (cherry picked from commit 89a55fa65acbd1e7527f304d04cabd47d2615b66) commit 149cb049aadf93d420009599476568a5b829f6e6 Author: Łukasz Wojniłowicz Date: Wed Jul 25 15:43:02 2018 +0200 Try to fix tests on FreeBSD commit d58f1dd85a033628b0c59ae38506aca848eaf798 Author: Łukasz Wojniłowicz Date: Wed Jul 25 15:31:00 2018 +0200 Revert "Fix QSQLCipher on MinGW" This reverts commit 754db8aab87bbe5047100fb88e56a57719366881. commit 076487d530fd11488411bf936385f06a45f482b1 Author: Thomas Baumgart Date: Wed Jul 25 08:28:56 2018 +0200 Improve previous change set commit 8bbc7c66f02829da45dfb3480156358f6d447234 Author: Łukasz Wojniłowicz Date: Tue Jul 24 20:58:51 2018 +0200 Fix test failure on MSVC commit 3ef14c87fe24dbb47940b44668f93aba4280e243 Author: Łukasz Wojniłowicz Date: Tue Jul 24 20:58:39 2018 +0200 Try to fix QSQLCipher on MinGW commit 18cf542243def84fd2acee88170a81262a3209e0 Author: Thomas Baumgart Date: Mon Jul 23 21:03:52 2018 +0200 Support online web source providing price pairs without decimal Manually cherry-picked from 3cc0235040fcfa4566cbb262e46348a0721c012d and adjusted BUG:396797 commit 754db8aab87bbe5047100fb88e56a57719366881 Author: Łukasz Wojniłowicz Date: Mon Jul 23 18:38:25 2018 +0200 Fix QSQLCipher on MinGW commit 9da135d4bc90e36507c49113fd07089eece7090b Author: Łukasz Wojniłowicz Date: Sun Jul 22 07:59:49 2018 +0200 Create XML storage helper Parts of MyMoneyReport and MyMoneyBudget are stored as XML in SQL storage hence the need of separate xmlstoragehelper library. SQL storage plugin will either remain with XML dependency or an another solution (preferably without XML) will be found. Differential Revision: https://phabricator.kde.org/D14271 commit c7e192b7b28976eba96116cfb95847b62c03d35d Author: Thomas Baumgart Date: Sun Jul 22 15:51:45 2018 +0200 Resolve compiler warning commit 6334f07e9f7c953dd7852bf7734212a1862c7a0c Author: Thomas Baumgart Date: Sun Jul 22 15:51:32 2018 +0200 Fix comment to show up at the right spot commit f1e4269365047765a2ae90810fd126f39bd19f96 Author: Thomas Baumgart Date: Sun Jul 22 10:32:36 2018 +0200 Fix expression to resolve warning commit 3b71d45a4ad200aa077b9f258b74ecd7df71635c Author: Łukasz Wojniłowicz Date: Sat Jul 21 21:22:09 2018 +0200 Try to fix SQLCipher on FreeBSD commit 1a2bc9020042a87a9e838edaec37d669730848a7 Author: Łukasz Wojniłowicz Date: Sat Jul 21 20:58:06 2018 +0200 Try to fix SQLCipher on FreeBSD commit f81002ece35b496f1d2d8c0a755e40e47242cd3b Author: Łukasz Wojniłowicz Date: Sat Jul 21 13:06:27 2018 +0200 Move more writing methods to XML storage Differential Revision: https://phabricator.kde.org/D14261 commit d9776f3497f5edfdef34a5a85784af9f9cc75414 Author: Łukasz Wojniłowicz Date: Sat Jul 21 07:10:10 2018 +0200 Move MyMoneySchedule writing to XML storage Differential Revision: https://phabricator.kde.org/D14257 commit b27c44b1b693802e2c3dfb3626d64944aed0ac64 Author: Łukasz Wojniłowicz Date: Wed Jul 18 20:26:22 2018 +0200 Try to fix SQLCipher on FreeBSD commit 2a75cebac69d86776e0a66bc27bec3b25be20fab Author: l10n daemon script Date: Wed Jul 18 03:30:39 2018 +0200 GIT_SILENT made messages (after extraction) commit 2be9278ce788f59b044e43f3b04efc9e72fe5baa Author: Thomas Baumgart Date: Tue Jul 17 08:34:07 2018 +0200 Update title of dialog depending on account type and action commit 136e3c8a8210395c203a7583978620e50a04edac Author: Thomas Baumgart Date: Mon Jul 16 21:11:31 2018 +0200 Fix broken links on welcome page commit ea34b91bc46ce2b84df1f3277fb29c3cf361a4d2 Author: Łukasz Wojniłowicz Date: Sat Jul 14 22:14:21 2018 +0200 Move MyMoneySplit reading and writing to XML storage It has been inadvertently omitted from the last patch. Old read methods are still around but only for an easy comparison with new methods. Differential Revision: https://phabricator.kde.org/D14125 commit beea52cd9a851c4086dd761f63462af189ffbd61 Author: Łukasz Wojniłowicz Date: Mon Jun 25 06:40:40 2018 +0200 Allow storing SQLite through SQLCipher Differential Revision: https://phabricator.kde.org/D13817 commit 40f6b25bcef2a92d21b8e8b97aa7026e17780c30 Author: Thomas Baumgart Date: Sun Jul 15 13:52:51 2018 +0200 Fix previous commit Removed one set of parenthesis. commit 71e207e0afb7413e5961add9f6325591459fe3f8 Author: Łukasz Wojniłowicz Date: Sun Jul 15 12:46:06 2018 +0200 Try to fix build commit 35116d6fc1ee9c253afb8284fb53ed00c5ce122d Author: Łukasz Wojniłowicz Date: Sat Jul 14 16:46:58 2018 +0200 Add test utilities It's mostly rename from reports_testcommon. I think it should be a center place for testing every class in KMM and not only reports. Differential Revision: https://phabricator.kde.org/D14115 commit ecef92d67ee7401f8c320e90b47c7db8ac04bd6a Author: l10n daemon script Date: Sun Jul 15 05:16:58 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 90e6277dd1d8c414d9f960f7c6d6aa8b0057b5cf Author: Łukasz Wojniłowicz Date: Sat Jul 14 11:29:54 2018 +0200 Fix xml file saving on Windows Patch sent by: ocoole Differential Revision: https://phabricator.kde.org/D13465 commit e4d384d34a91eb6024800ca13ecb1696af72cd96 Author: Łukasz Wojniłowicz Date: Sat Jun 9 22:27:06 2018 +0200 Move XML read methods to storage plugin This is a step in XML encapsulation direction. Because overall it's a big undertaking, only read methods from mymoneystoragexml has been moved. Save methods will follow later. Because it's an error prone undertaking, old read methods have been left untouched for a quick and transparent testing. MyMoneyObjects are loaded in mymoneystoragexml as follows: *1) using old way (constructor accepting QDomElement), 2) using new way (static read methods in mymoneystoragexml), *3) returned object from old and new way are compared and inequality is signaled in terminal, *4) returned object from old way is discarded and object from new way is going further, *only for testing, will be removed with underlying code in the accepted patch Differential Revision: https://phabricator.kde.org/D13831 commit fcb154973cd160e7861748ae79d45acba618645a Author: l10n daemon script Date: Thu Jul 12 05:11:24 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 986afbb02ccde6f0c7fc2da8ea6cab3fa52f8eba Author: Thomas Baumgart Date: Tue Jul 10 19:47:47 2018 +0200 Removed unused code commit 34d82ee6c600e567cc7a55a8958d6d9b052200ab Author: Thomas Baumgart Date: Mon Jul 9 17:14:29 2018 +0200 Fix compilation of debug output code commit 6d3bbd6415c54b6e12de7d20183eb11c6d8d3c43 Author: Thomas Baumgart Date: Mon Jul 9 17:13:50 2018 +0200 Fix construction of graphs that do not start at column zero commit 3d799099ee4cd6a27245a054b087873534eeb8b7 Author: Thomas Baumgart Date: Mon Jul 9 17:12:55 2018 +0200 Fix construction of tooltip in graphs commit 7228ba27a926532ef769347dfab36732212d22d5 Author: Thomas Baumgart Date: Mon Jul 9 17:08:00 2018 +0200 Add missing parameter to function call commit ac6976abda0e24d3461593e12765031298d22e0a Author: Łukasz Wojniłowicz Date: Fri Jun 22 18:17:39 2018 +0200 Move reports drawing to reports view plugin This patch completes encapsulation of reporting features in KMyMoney. If a report is needed then it should be returned as: 1) QWidget It will then be possible to show report outside of KReportsView and handle it completely inside KReportsView. This approach will allow us embedding any report anywhere with configuration controls built in a report. 2) QString Some reports aren't graphical charts, so they need textual representation. Disadvantage of this approach is that chart cannot be handled inside KReportsView. Differential Revision: https://phabricator.kde.org/D13687 commit 2b780c6af2cc131ff193035a7dfef41df0086af7 Author: l10n daemon script Date: Mon Jul 9 05:10:39 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit b7f43fbba82102ef783f81b6a9c4447e3402b240 Author: Thomas Baumgart Date: Mon Jul 2 08:59:24 2018 +0200 Added missing include of header file commit 7561bb34fa313b4d4fe2c9700507faa9d4fe8e80 Author: l10n daemon script Date: Mon Jul 2 06:56:55 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 98b15dedb0f3daa558c5b5f69aab06aa9d9d0fdf Author: l10n daemon script Date: Mon Jul 2 05:10:42 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit ef72f1c1c7585ace42c924888b42092fbcd3a4d2 Author: Thomas Baumgart Date: Sun Jul 1 13:09:49 2018 +0200 Resolve another compiler warning commit 0bde14c1bdc003d3419aa79971132128e091db6f Author: Thomas Baumgart Date: Sun Jul 1 11:46:42 2018 +0200 Solve compile problems on FreeBSD commit 36b19bd08a9e9c5b2723d98edb19f0cb357b450a Author: Thomas Baumgart Date: Sun Jul 1 11:46:07 2018 +0200 Revert "Try to resolve compiler warnings" This reverts commit a5c737f7c4933845c546b12c43df3a19e016b075. commit a5c737f7c4933845c546b12c43df3a19e016b075 Author: Thomas Baumgart Date: Sun Jul 1 11:27:26 2018 +0200 Try to resolve compiler warnings This is a try to fix the warning about unused return values shown in https://build.kde.org/job/Extragear%20kmymoney%20kf5-qt5%20SUSEQt5.9/429/warnings31Result/ commit 172bc0c10da3cd77fcbd8eba33af9275e60901a2 Author: Thomas Baumgart Date: Sun Jul 1 08:54:13 2018 +0200 Add field for institution's website URL Summary: This change adds an edit field for the URL of a bank's website to the institution dialog. For security reasons, allow the https protocol is used. The protocol does not need to be entered as part of the URL and in case it is, it will be removed from the URL part. A button right to the edit field allows to open the URL entered in the browser. Whenever the URL text changes, a check will be started to verify that the URL entered accesses a web server. In case it does, the button is enabled otherwise disabled. In case a favicon is found at the URL it is placed on the button otherwise, the standard KMyMoney icon for institutions is used. In case of an invalid URL the icon will be removed from the button. No check is performed that it is really your bank's website that opens when pressing the button. {F5982397} Button with a favicon drawn from the website. {F5982404} Same area with an account that is not managed by an institution. {F5982419} And an institution that does not provide a favicon, so we use our own. Test Plan: Added false URLs, URLs that do not provide a favicon and ones that provide a favicon. Saved data to file and checked that the KVP entries are filled. Reviewers: #kmymoney, ostroffjh, wojnilowicz Reviewed By: #kmymoney, wojnilowicz Differential Revision: https://phabricator.kde.org/D13707 commit aef65ed19fe63edc0cda55ca35f8a5369a70665a Author: l10n daemon script Date: Sun Jul 1 05:38:17 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 825072bd59a4d86fe48af2bcdae743ddd3d8253f Author: l10n daemon script Date: Fri Jun 29 05:19:39 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 5fb9f6f2ff3749c1416eecf37819d345ae9ff90a Author: l10n daemon script Date: Wed Jun 27 05:31:03 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 2ab008be762da29122426ad9e41eccd44d00bac3 Author: l10n daemon script Date: Tue Jun 26 05:38:22 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 5fa45feb13fbd280cb151a8664dab9d5169be105 Author: Thomas Baumgart Date: Mon Jun 25 21:50:34 2018 +0200 Revert "Try to fix MyMoneyException on FreeBSD" This reverts commit 8e32f27115265ae231dc410491b42dc87e56ba8d. It does not solve the problem and fails for me with the following error: /home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyexception.h:64:3: error: exception specification of explicitly defaulted copy constructor does not match the calculated one commit b4d44ae83540805e6d3b58a5376db7674a245f36 Author: Łukasz Wojniłowicz Date: Tue Jun 19 18:35:27 2018 +0200 Move encryption settings to XML storage plugin Encryption with GPG pertains only to XML storage plugin, so it should be in its configuration instead of in global configuration. Differential Revision: https://phabricator.kde.org/D13615 commit b7c44b7f705cd8d106e39a4a94758388fd59da61 Author: Łukasz Wojniłowicz Date: Sun Jun 10 13:56:08 2018 +0200 Prepare for XML storage separation Goal of this patch is to facilitate separation of XML saving and reading methods to XML storage plugin by: 1) adding new constructor for MyMoneyObjects The new constructor accepts id, so an MyMoney object will be created in XML storage plugin at the spot and not by a copy from another object. That's one constructor more for every MyMoneyObject, but there will be one constructor (the one with QDomElement) less after complete encapsulation of XML support in KMyMoney 2) moving all remaining enums to mymoneyenums Some enums were changed to enum class, so type safety is enhanced a little bit. Differential Revision: https://phabricator.kde.org/D13581 commit e527dd190b1069dab5a3ad560a5a732f2ca2f760 Author: Łukasz Wojniłowicz Date: Thu Jun 7 19:47:29 2018 +0200 Format reports headers according to the KDE guidelines Purpose of this patch is to tidy up source code headers. Right now we've got three different types of headers (accountsviewproxymodel.cpp, payeeidentifier.cpp, kcurrecycalculator.cpp). This patch will standardize them to one according to https://community.kde.org/Policies/Licensing_Policy#GPL_Header Moreover, there are some names in the headers, which have not even touched the file, so it's false authorship. Those names have been removed. List of the names to remove has been taken from: 1) CVS logs (http://kmymoney2.cvs.sourceforge.net/), 2) git logs, 3) KMM Sourceforge developer mailing list (https://sourceforge.net/p/kmymoney2/mailman/kmymoney2-developer/) 4) CVS stats (http://kmymoney2.sourceforge.net/kmymoney2-stats/authors.html) 5) ChangeLog of CVS Differential Revision: https://phabricator.kde.org/D13414 commit 13124d2de6a0ce5b75b5bc55c9201ef940b4315a Author: Łukasz Wojniłowicz Date: Thu Jun 7 19:21:25 2018 +0200 Format widget headers according to the KDE guidelines Purpose of this patch is to tidy up source code headers. Right now we've got three different types of headers (accountsviewproxymodel.cpp, payeeidentifier.cpp, kcurrecycalculator.cpp). This patch will standardize them to one according to https://community.kde.org/Policies/Licensing_Policy#GPL_Header Moreover, there are some names in the headers, which have not even touched the file, so it's false authorship. Those names have been removed. List of the names to remove has been taken from: 1) CVS logs (http://kmymoney2.cvs.sourceforge.net/), 2) git logs, 3) KMM Sourceforge developer mailing list (https://sourceforge.net/p/kmymoney2/mailman/kmymoney2-developer/) 4) CVS stats (http://kmymoney2.sourceforge.net/kmymoney2-stats/authors.html) 5) ChangeLog of CVS Differential Revision: https://phabricator.kde.org/D13413 commit 8e32f27115265ae231dc410491b42dc87e56ba8d Author: Łukasz Wojniłowicz Date: Tue Jun 19 17:33:02 2018 +0200 Try to fix MyMoneyException on FreeBSD commit 30e687cc8b29c19e9e4dfe9aa7938a7baa70ed12 Author: Łukasz Wojniłowicz Date: Mon Jun 25 19:26:33 2018 +0200 Fix undefined ENABLE_UNFINISHEDFEATURES commit 61fff98b33b2127c8a07e5c41b8b1e962f501676 Author: Thomas Baumgart Date: Fri Jun 22 16:10:09 2018 +0200 Fix compilation with Qt5.11 CCBUG: 395227 commit 604dae022e9544e34e0c411ca1d79f29fbd6f049 Author: Jonathan Riddell Date: Thu Jun 21 14:38:55 2018 +0100 add missing header include commit b5d8e804f839029caca4357c3e0a0fe692e8a477 Author: l10n daemon script Date: Thu Jun 21 07:13:37 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 7fac0afc2b1cfbeba85d91b558ce435153a4e3b7 Author: l10n daemon script Date: Thu Jun 21 06:09:56 2018 +0200 GIT_SILENT made messages (after extraction) commit 6fefc55a6398eadd0c9585b1145a8dd64b10eb36 Author: l10n daemon script Date: Thu Jun 21 05:33:43 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 49ccbe44607db0ad6c71f19131c761f3f601189e Author: l10n daemon script Date: Thu Jun 21 03:33:25 2018 +0200 GIT_SILENT made messages (after extraction) commit 3d640881b17f81090b513ef316aeaee07177c83e Author: Thomas Baumgart Date: Mon Jun 18 14:51:52 2018 +0200 Keep Home view enabled all the time The home view must remain enabled even when no file is open commit 05ce669ed209af46120088351a8baad62db86bb6 Author: Thomas Baumgart Date: Mon Jun 18 14:51:05 2018 +0200 Enable Q_ASSERT in debug builds commit 72263004760985f6acdf67905764402dcd0e372c Author: Thomas Baumgart Date: Sun Jun 17 17:18:32 2018 +0200 Fix detection of clientuid support commit 1b0a620291afda776888fb8c99c9efba2afde41e Author: Thomas Baumgart Date: Sat Jun 16 16:18:57 2018 +0200 Simplify signal handling between engine and models Summary: Make the signal connection and disconnection more readable Reviewers: wojnilowicz Reviewed By: wojnilowicz Differential Revision: https://phabricator.kde.org/D13519 commit a4e991f8174a16f1cf9ec841f06af671477b616c Author: Thomas Baumgart Date: Wed Jun 13 18:15:04 2018 +0200 Prevent mouseMoveEvents in new ledger view commit 7601079e31971d30514775b528db9a7dbcbf10c8 Author: Thomas Baumgart Date: Wed Jun 13 18:14:09 2018 +0200 Reduce vertical spacing of form elements commit 457d0ff6dba8c5c8d3f01ba3a6d37c51eab36b14 Author: Thomas Baumgart Date: Wed Jun 13 12:16:43 2018 +0200 Modernize WidgetHintFrame object commit b20464b87c969e9c3001dc050676fedc8053edcc Author: Thomas Baumgart Date: Wed Jun 13 10:07:32 2018 +0200 Revert "Try to find problem with exceptions on FreeBSD" This reverts commit 176986e37ebb57d8292233dc5275495616b9f985. commit 176986e37ebb57d8292233dc5275495616b9f985 Author: Thomas Baumgart Date: Wed Jun 13 09:55:28 2018 +0200 Try to find problem with exceptions on FreeBSD commit ab29f08a258b1f59b696d4b8a802cb0500fee876 Author: Thomas Baumgart Date: Wed Jun 13 08:23:54 2018 +0200 Adjust cmake module to setup LibOFX build vars for FreeBSD commit 143aa9fe1d944ad8ceeb51eacf3db132fe48f40c Author: Yuri Chornoivan Date: Wed Jun 13 07:55:51 2018 +0300 Fix minor typo commit f16004d5b3acf97743c37587f6d6723f950c39cc Author: Thomas Baumgart Date: Tue Jun 12 23:16:28 2018 +0200 Replace for with foreach for loop over list commit 68a686716680aa4bae5ddfee944efd56cf6e97e1 Author: Thomas Baumgart Date: Tue Jun 12 08:43:42 2018 +0200 Provide timezone offset for OFX import Summary: In certain constellations the post date could be off by one day. This can happen, when your institution provides timestamps that differ from the one of your local time. This change allows to adjust the timestamps during import so that the date will be shown correct. The new setting can be used to adjust the timestamps of the transactions during import to reflect your local time. It does not affect previously imported transactions. The offset is formatted as HH:MM. If you are located west of your bank's server than enter a negative time, in case you are located east of it enter a positve time. If you are not sure, leave this setting at 0:00. See also: https://forum.kde.org/viewtopic.php?f=69&t=152300 {F5887276} This shows the new setting with an offset of -3 hours. Test Plan: Requirement is to have an OFX server in different timezone. Make sure to import a transaction that shows the problem of a post date off by one day. Delete the transaction in question. Setup the correction value in the new account online setting and import. Repeat the import and verify that the post date is now correct. Reviewers: ostroffjh Differential Revision: https://phabricator.kde.org/D13293 commit 3edd0d31100a4889e9c41fce960c2e35c5352f91 Author: Yuri Chornoivan Date: Tue Jun 12 07:37:54 2018 +0300 Fix minor typo commit 0b87da170a5be4b0ecb11db9fb7980f6c192206c Author: Thomas Baumgart Date: Mon Jun 11 07:55:57 2018 +0200 Keep current scroll position when reloading page Summary: I don't have an environment supporting QWebEngine so I need some help here. Patches and testers welcome. BUG: 391981 FIXED-IN: 5.0.2 Test Plan: Compile and run with QWebKit and QWebEngine Reviewers: wojnilowicz, asturmlechner Reviewed By: wojnilowicz Differential Revision: https://phabricator.kde.org/D11450 commit 5ca438e0943741c17d54d8e8220e49d1399b232c Author: Thomas Baumgart Date: Mon Jun 11 14:41:47 2018 +0200 Improve save as storage type selection dialog commit 217ba253c2f7ce1f1983273745dfd8ace7884988 Author: Thomas Baumgart Date: Sun Jun 10 20:38:28 2018 +0200 Fix state of edit/delete transaction buttons Make sure that the parameter list is never the same as m_selectedTransactions since the first thing that happens inside this method is to clear m_selectedTransactions. In some commit bfa516d0914387be0910f249ade10a094babfd59 Author: Łukasz Wojniłowicz Date: Sat Jun 2 14:57:23 2018 +0200 Refactor file menu The purpose of this patch is to make file opening transparent. Changes: 1) no wild attaching and detaching storage That was cause of a memory leak. Now a storage is created and attached only after successful opening of a file. 2) new KMyMoneyApp::Private::fileAction It's central place for gathering all actions, app needs to undertake after a change in load state of a file. 3) user can choose to save newly created file as sql Previously only xml was possible. Now user can even choose to not save it at all, which makes app independent from any storage plugin. 4) app doesn't crash if no storage plugin is loaded 5) no unnecessary update of actions which depend on load state of file Differential Revision: https://phabricator.kde.org/D13408 commit 7a3aba071f633ecf1339347defd13b5cfc0f6af6 Author: Łukasz Wojniłowicz Date: Thu Jun 7 17:48:07 2018 +0200 Remove redundant CMake statements Exceptions are enabled globally by kde_enable_exceptions, so there is no need for separate kde_target_enable_exceptions. target_compile_features should be useless as we already should have all features we request by requesting a compiler compatible with C++14. Differential Revision: https://phabricator.kde.org/D13409 commit 1183eaec5d2626dc7afbc39df1643e6470b8c870 Author: Łukasz Wojniłowicz Date: Sun Jun 3 10:37:20 2018 +0200 Enable foreign keys support in SQLite Deleting from kmmOnlineJobs leaves kmmSepaOrders in tact because there is no: 1) ON DELETE relation between kmmSepaOrders and kmmOnlineJobs, 2) foreign_keys is disabled on default on SQLite, which makes ON DELETE possible. Leaving kmmSepaOrders in tact prevents saving new records to it, because there aren't overridden automatically and thus regarded as non unique, which fails the requirement of INSERT. We can easily recreate kmmSepaOrders (with ON DELETE constraint) without taking its content into account, as it would be deleted anyways. Differential Revision: https://phabricator.kde.org/D13295 commit 8658b8eb6b1b1b5b78ccbfd566d86bcbabf88300 Author: Łukasz Wojniłowicz Date: Sat Jun 9 09:18:31 2018 +0200 Use QVERIFY_EXCEPTION_THROWN in MyMoneyMoney test It asserts that library has been built with exception handling enabled. commit 8361512c226452d891d7600448c12209adbc2053 Author: Thomas Baumgart Date: Sun Jun 10 16:24:20 2018 +0200 Prevent crash on destruction of KTagContainer I could happen, that the connected KMyMoneyMVCCombo widget looses the focus and as part of it emits lostFocus() before the connection was removed as part of the destruction in the Qt main loop but the KTagContainer was already deleted. This causes a crash of KMyMoney as the KTagContainer object does not exist anymore. This change removes the connection as part of the KTagContainer destruction so that the above mentioned scenario cannot happen anymore. commit 2400f611ba3887dbd0eee86a18565f71d411f76d Author: Christian Dávid Date: Sun Jun 10 12:00:27 2018 +0200 Added currency Cuban Convertible Peso (CUC) Cuban Convertible Peso (CUC), symbol "CUC$" not added because it should be less useful than just using CUC. commit f2e799fadcfd76f24f2a2aad2d761e2839015c7a Author: Thomas Baumgart Date: Sun Jun 10 11:57:35 2018 +0200 Make sure 'new category' is always available 'New category' is always available just like 'New account'. No need to limit it to the categories view commit 6e85b74311985db01e8ccc44eb1e9e38ca093357 Author: Thomas Baumgart Date: Sat Jun 9 22:48:25 2018 +0200 Resolve more compiler warnings commit 0940d36be66b499c3d2fab6514a3bbf9dc8bd809 Author: Thomas Baumgart Date: Sat Jun 9 22:08:58 2018 +0200 Resolve compiler warning commit a5e60b597f6c12d01deb761145e25b3409cc058f Author: Thomas Baumgart Date: Sat Jun 9 22:08:45 2018 +0200 Make sure 'new category' is available when storage is open commit 380e9d60f3817fd2db0b6e56fa68570eca02bd0a Author: Thomas Baumgart Date: Thu Jun 7 13:49:34 2018 +0200 Don't change last selected view during application exit This amends the last commit in such that it does not change the stored setting of the last view when it might be changed behind the back of the user when views provided by plugins are unloaded as part of application shutdown. commit eb44ed0dfeb25a5f4765bce423d4db7b4f8c55a8 Author: Thomas Baumgart Date: Thu Jun 7 13:05:12 2018 +0200 Update last selected view in settings After recent changes in the view logic, the last selected view was not updated properly anymore. BUG: 395100 FIXED-IN: 5.1.0 commit c88f41f13b20c1fb35b67e5c0c36213edb28e681 Author: Thomas Baumgart Date: Thu Jun 7 13:00:06 2018 +0200 Make settings are synced to disk on app quit commit 2f823a4603f1d9c823f3498e74f3fa05960e2383 Author: Thomas Baumgart Date: Thu Jun 7 09:44:08 2018 +0200 Improve deletion of unused widgets in transaction editor commit cc0c658ed60668ee71f2a508531788c527f5fcdd Author: l10n daemon script Date: Thu Jun 7 06:30:06 2018 +0200 GIT_SILENT made messages (after extraction) commit f8fb3b0743e42ce4093c3a6ca455f019b6f1c2c7 Author: l10n daemon script Date: Thu Jun 7 03:35:53 2018 +0200 GIT_SILENT made messages (after extraction) commit 65c4882148eb7d2e5503977dfa9794977391edbf Author: Thomas Baumgart Date: Wed Jun 6 08:41:34 2018 +0200 Remove unused comments commit 35e6212fed44e3aaa9c64ff7e1f08eed61398d51 Author: Thomas Baumgart Date: Wed Jun 6 08:41:01 2018 +0200 Simplify libofx clientuid support detection commit 9d53da8867d4e986c703d5b581d713253f533ed6 Author: Thomas Baumgart Date: Tue Jun 5 17:40:01 2018 +0200 Remove extra column at end of non investment lines in csv export Cherry-picked from 8b52797a5c960966988ff04d85593e7af0287af9 and adjusted to master commit 3c5c5070b03762f36f83f88f8204b6a647ed86cd Author: Thomas Baumgart Date: Tue Jun 5 17:36:42 2018 +0200 Write correct number of columns for investment transactions to csv file Cherry-picked from 3a89db9fac1294a1bc3cfe09551caeef40572bde and adjusted to master commit 638b0eacfdcc79cf67db747889f50381259fd703 Author: Thomas Baumgart Date: Tue Jun 5 17:33:26 2018 +0200 Allow field delimiter as character in CSV exports This commit fixes all fields which may have field separators like payee, acccount, category, memo, number and money related fields. Additional fixes: - the commit also handles double quotes inside string fields according to RFC 4180 Note: The previous implementation removed single quotes from memo fields, which is now applied to all string fields because all string fields are formatted by the same method. If this could be removed, please file a related request. BUG:395025 Test Plan: compiled and exported to csv on linux Reviewers: #kmymoney, tbaumgart Reviewed By: tbaumgart Subscribers: tbaumgart Differential Revision: https://phabricator.kde.org/D13330 Signed-off-by: Ralf Habacker Cherry-picked from 12fa3bbffb164737c8fd0b564c5596c4933a5d35 and adjusted for master commit 11fa00ff2b8ae64109d9b74ecfa6f0c80b2daa76 Author: Thomas Baumgart Date: Tue Jun 5 13:24:03 2018 +0200 Try to fix build on arm commit 6c39704b37ab77ae19f7c425aeca3d6b2c34453e Author: Thomas Baumgart Date: Tue Jun 5 13:23:41 2018 +0200 Fix another int conversion warning commit 47788f07de122326c54da515453ef1c42092a8d4 Author: Thomas Baumgart Date: Tue Jun 5 09:59:07 2018 +0200 Fix some more integer conversion warnings commit f84f2b4b78591b554887c86a76a815c1eef45a5e Author: Thomas Baumgart Date: Tue Jun 5 09:41:17 2018 +0200 Fix CSV Export of Investment Accounts The CSV-Export does not issue transactions in non-English installations. Fixed by using the accountType() member instead of a possibly translated string. cherry-picked from 97d1683c0329326a82bbf1e445cab37f9f4474ee and adjusted to master BUG:395040 commit c1548db1636116f1d66986056966465fc1883a0c Author: Thomas Baumgart Date: Tue Jun 5 07:15:13 2018 +0200 Display correct name of closed account Detecting a closed account worked but the name provided to the user did not match reality. This change extracts the right name. Candidate for a backport to 4.8 which contains a similar wrong logic. commit 12b53c99fb611bb0349180ef53a629f2db676945 Author: Thomas Baumgart Date: Mon Jun 4 20:18:48 2018 +0200 Fix a bunch of integer conversion warnings commit ab5d1d1253c24bfa661b90603bcfcc273fe35d64 Author: Thomas Baumgart Date: Mon Jun 4 20:17:33 2018 +0200 Try to fix MSVC error C2276 commit dd77e1f94f1d6c56bc4ca59e5e6380f7f41a7fee Author: Thomas Baumgart Date: Mon Jun 4 19:58:25 2018 +0200 Correctly version libkmm_payeeidentifier_loader Now all shared libraries have a valid so version CCBUG: 394970 commit 77c89b8bd73b33407e7e2ed950b08580b645fb23 Author: Thomas Baumgart Date: Mon Jun 4 17:16:18 2018 +0200 Fix macro expansion which causes trouble on MSVC commit 53f1785233ab2c0708e5a93b87a396fc279a8471 Author: Thomas Baumgart Date: Mon Jun 4 16:45:38 2018 +0200 Resolve warnings about unused variables Keep those keys for historic reasons commit ca2290dc5cbd30ee53269e97ff1605f55c35f447 Author: Thomas Baumgart Date: Mon Jun 4 16:44:59 2018 +0200 Add warning about unused const variables commit c8b202f550a0fe32a95ca0c547029ee15274f125 Author: Thomas Baumgart Date: Mon Jun 4 16:20:21 2018 +0200 Reload widget to use newly created security A security created on the fly could not be used in the current edit session. This change fixes this problem. BUG: 394394 FIXED-IN: 5.0.2 (cherry picked from commit 87d3c4ef0cbe1bddd19df2ef64b762c8c82b349d) commit 87d3c4ef0cbe1bddd19df2ef64b762c8c82b349d Author: Thomas Baumgart Date: Mon Jun 4 16:15:40 2018 +0200 Reload widget to use newly created security A security created on the fly could not be used in the current edit session. This change fixes this problem. BUG: 394394 FIXED-IN: 5.1.0 commit 8bdae55854dd96171e0306cc0ee1c6317b6e4aa4 Author: Thomas Baumgart Date: Mon Jun 4 15:16:25 2018 +0200 Correctly version libkmm_models.so CCBUG: 394970 commit 0e75cd0973d7e19d09efd4ac99a4eee0e521f6c5 Author: Thomas Baumgart Date: Mon Jun 4 11:40:09 2018 +0200 Adjust usage of thousands separator Modifications according to the analysis in bug 328050 OFX: the modified code is commented out and only used for test purposes CSV: just a simplification of the code, no change in functionality CCBUG: 328050 commit 239b4f1568cbad2ccbdb0a4666f34eaa3070418c Author: Łukasz Wojniłowicz Date: Sun Jun 3 13:25:19 2018 +0200 Fix some build warnings Differential Revision: https://phabricator.kde.org/D13298 commit 724691bfdc3bdb651fd5b4f7480edd9591f1972e Author: Łukasz Wojniłowicz Date: Sun Jun 3 11:48:13 2018 +0200 Use unsigned int for denominator in MyMoneyMoney AlkValue has no constructor for qint64 aka signed64. That saves us compiler warning and maybe test will work again on FreeBSD. Differential Revision: https://phabricator.kde.org/D13296 commit 258ac558b1c8fafaaa15d3f9077dd731ae42cb58 Author: Thomas Baumgart Date: Sun Jun 3 13:38:26 2018 +0200 Added testcases for MyMoneyMoney ctors commit 84f0a9b92d4191dc4d7982728be50b62cbc13f3e Author: Łukasz Wojniłowicz Date: Sat Jun 2 16:43:07 2018 +0200 Fix the build, try 3 commit d881e431effecbd5e747f48772c05d2b1a271b60 Author: Łukasz Wojniłowicz Date: Sat Jun 2 16:34:14 2018 +0200 Fix the build, try 2 commit 4be5ec00eacef5f5534a2da5a705d2a05329615e Author: Łukasz Wojniłowicz Date: Sat Jun 2 16:24:35 2018 +0200 Fix the build, try 1 commit dc335bcaf0d9451df16067c2ee4fc3104630d780 Author: Łukasz Wojniłowicz Date: Fri Jun 1 16:25:49 2018 +0200 Pluginize XML Storage The goal of this patch is to open supported files in alike ways i.e. through KMyMoneyPlugin::StoragePlugin. This is the first step to make Qt5::Xml dependency optional by encapsulating saving as XML file in a plugin. The patch is transient as "opening", "saving" and "saving as" could be made consistent in kmymoney.cpp. GNC reader could also be made consistent with XML and SQL storage. KMyMoneyPlugin::StoragePlugin could also be extended by identification of its own file formats. With this patch I want to know if all works well. Differential Revision: https://phabricator.kde.org/D13279 commit 61959371ce7070502b4ede81573104f2f787e6d4 Author: Łukasz Wojniłowicz Date: Sat Jun 2 15:58:50 2018 +0200 Format dialogs headers according to the KDE guidelines Purpose of this patch is to tidy up source code headers. Right now we've got three different types of headers (accountsviewproxymodel.cpp, payeeidentifier.cpp, kcurrecycalculator.cpp). This patch will standardize them to one according to https://community.kde.org/Policies/Licensing_Policy#GPL_Header Moreover, there are some names in the headers, which have not event touched the file, so it's false authorship. Those names has been removed. List of the names to remove has been taken from: 1) CVS logs (http://kmymoney2.cvs.sourceforge.net/), 2) git logs, 3) KMM Sourceforge developer mailing list (https://sourceforge.net/p/kmymoney2/mailman/kmymoney2-developer/) 4) CVS stats (http://kmymoney2.sourceforge.net/kmymoney2-stats/authors.html) 5) ChangeLog of CVS Differential Revision: https://phabricator.kde.org/D13161 commit 6e3e8f3d8250ff954bcff552dc0021992935405c Author: Łukasz Wojniłowicz Date: Sat Jun 2 15:05:05 2018 +0200 Format models headers according to the KDE guidelines Purpose of this patch is to tidy up source code headers. Right now we've got three different types of headers (accountsviewproxymodel.cpp, payeeidentifier.cpp, kcurrecycalculator.cpp). This patch will standardize them to one according to https://community.kde.org/Policies/Licensing_Policy#GPL_Header Moreover, there are some names in the headers, which have not event touched the file, so it's false authorship. Those names has been removed. List of the names to remove has been taken from: 1) CVS logs (http://kmymoney2.cvs.sourceforge.net/), 2) git logs, 3) KMM Sourceforge developer mailing list (https://sourceforge.net/p/kmymoney2/mailman/kmymoney2-developer/) 4) CVS stats (http://kmymoney2.sourceforge.net/kmymoney2-stats/authors.html) 5) ChangeLog of CVS Differential Revision: https://phabricator.kde.org/D13159 commit af378c83b4efac70acadaae7ff8a9388cc91750c Author: Łukasz Wojniłowicz Date: Sat Jun 2 11:10:28 2018 +0200 Fix reading online jobs in SQL storage commit 93df569eb8d6c56ce4b47b5653a2460d61e3b953 Author: Łukasz Wojniłowicz Date: Sat Jun 2 09:57:10 2018 +0200 Delete item after it has been removed BUG: 392735 FIXED-IN: 5.0.2 commit 303e9a1e26f36b3f5e214950330191802197198f Author: Łukasz Wojniłowicz Date: Sun May 27 16:56:51 2018 +0200 Move ibanbicdata to a plugin This patch makes Qt5::Sql dependency optional instead of required. IBAN/BIC data provides the same functionality to KMM, but now is used only if available. Alas the feature did not work properly even before the patch, so it's disabled by default. Changes: 1) new KMyMoneyPlugin::DataPlugin It returns information after providing keyword and information's type. It could be used not only for IBAN/BIC but also for new online quotes system. 2) all loaded plugins available in shared kmm_plugin We already have some parts of KMM where plugins are needed e.g. accounts view or online jobs outbox. Instead of building chain of passing plugin pointers we could have centralized plugins location. In that way we could even use one plugin in another one. 3) ibanbic and nationalaccount moved to kmm_mymoney Their definitions aren't optional and are required during a read of XML or DB file, so by not making them loadable on demand removes unnecessary step. The move was necessary also because of dependency hell of little libraries that were interdependent (circular dependency) and couldn't be set in any other configuration. 4) decimated kmm_payeeidentifier_loader and made it shared It was part of dependency hell. Let's hope that after this there will be no multiple definition issue with different compilers. Differential Revision: https://phabricator.kde.org/D13242 commit 216b3ad7d0e49df4e7cc2cd1b040f4cfb140777a Author: Thomas Baumgart Date: Sat Jun 2 10:28:30 2018 +0200 Fix 'User is asked to create a new category in splits table if change is aborted' BUG:344409 (cherry picked from commit 71c5d41b39fab3cfa5febbef796a32f55299bac7 and adjusted to match on master) commit 7c338ba2f839846b9aed219d64ef57822ef5dc42 Author: Łukasz Wojniłowicz Date: Sun May 27 19:26:17 2018 +0200 Format mymoney headers according to the KDE guidelines Purpose of this patch is to tidy up source code headers. Right now we've got three different types of headers (accountsviewproxymodel.cpp, payeeidentifier.cpp, kcurrecycalculator.cpp). This patch will standardize them to one according to https://community.kde.org/Policies/Licensing_Policy#GPL_Header Moreover, there are some names in the headers, which have not event touched the file, so it's false authorship. Those names has been removed. List of the names to remove has been taken from: 1) CVS logs (http://kmymoney2.cvs.sourceforge.net/), 2) git logs, 3) KMM Sourceforge developer mailing list (https://sourceforge.net/p/kmymoney2/mailman/kmymoney2-developer/) 4) CVS stats (http://kmymoney2.sourceforge.net/kmymoney2-stats/authors.html) 5) ChangeLog of CVS After removing some names, the headers look a bit bald :) so I've added some of the authors, that actually contributed to the files. There were also two contributors, who didn't have their accounts: 1) Carlos Eduardo da Silva 2) Alessandro Russo so I left them where they were, as they were only in few spots. Differential Revision: https://phabricator.kde.org/D12979 commit 839feeb80f5fe22a378c0a31e1c7584acb1658bf Author: Łukasz Wojniłowicz Date: Thu May 17 17:56:57 2018 +0200 Get rid of databaseStoreableObject Purpose of this patch is to encapsulate SQL support in KMyMoney. It strives to reduce KMyMoney dependencies by making Qt5::Sql optional. It should fix multiple definitions of payeeIdentifierLoader::createPayeeIdentifierFromSqlDatabase on MS Windows. Changes: 1) saving, removing, and modifying payee identifier and online tasks occurs in sqlstorage plugin, as mentioned objects doen't have to know how they will be saved and by which storage plugin. 2) there is a new mini-plugin called credittransfer_sepa_storageplugin to follow a pattern introduced by payee identifier mini plugins 3) sepaOnlineTransferImpl has been moved to mymoney to follow a pattern introduced by payee identifier. Besides it's mandatory to have it anyway, so no need to load it every time through a plugin interface Differential Revision: https://phabricator.kde.org/D13020 commit 9267f93c4d0b57d0405e2644d47d0fe5a753f760 Author: Thomas Baumgart Date: Sun May 27 16:39:14 2018 +0200 Fix check for empty database A freshly created database was reported as 'not empty' since creating a database writes an initial record into the kmmFileInfo table. commit c5a3c44b2a341d6efc1a55bc55dcff9ff5a594c8 Author: Thomas Baumgart Date: Sun May 27 09:16:32 2018 +0200 Fix construction of file based DB name on *NIX systems One cannot remove the leading slash which will turn an absolute file path into a relative one on *nix systems which in turn breaks the logic. commit e9b4420650c08209b9614d2761a8bdf0268deb9b Author: Thomas Baumgart Date: Sun May 27 09:15:09 2018 +0200 Avoid duplicate deletion The object pStorage points to is already deleted as part of the call to removeStorage() commit b979537747b1999634bf3165378ce77d073fae65 Author: Łukasz Wojniłowicz Date: Fri May 25 16:29:12 2018 +0200 Try to fix compilation on MinGW commit 724fad7d3e5e3163e7493abafc3eb6b6663576c0 Author: Marc Hübner Date: Fri May 25 16:24:25 2018 +0200 Silence warnings from external libraries on MSVC https://blogs.msdn.microsoft.com/vcblog/2017/12/13/broken-warnings-theory/ commit f835b240f165c17041ee0280b216421653c8d63f Author: l10n daemon script Date: Tue May 22 03:35:24 2018 +0200 GIT_SILENT made messages (after extraction) commit 06f06341779626a0174096dffe643dc0132b2357 Author: Thomas Baumgart Date: Sun May 20 19:01:02 2018 +0200 Added testcase to check exception handling Inspired by a problem in the exception handling on FreeBSD I added this testcase commit a26fe93dab9cd5dbdc2bd78d6e1df061b2a1e39e Author: Yuri Chornoivan Date: Sun May 20 09:06:12 2018 +0300 Fix minor typo commit dea9c55f32d5517e8b25f4acadcdb47515830d50 Author: Thomas Baumgart Date: Sat May 19 08:33:16 2018 +0200 Resolve compiler warning commit 6aec43beb40a6ce7783ecef7cda5ed2104af0e9e Author: Łukasz Wojniłowicz Date: Sat May 19 07:53:22 2018 +0200 Try to fix compilation on MacOS commit 284a03319c2d9b60d18d000ddefc27b580c264d9 Author: Łukasz Wojniłowicz Date: Thu May 10 14:41:00 2018 +0200 Refactor MyMoneyException class MyMoneyException changes in following way: 1) Untranslated exceptions, as normal user doesn't need to understand exceptions, only developers do, 2) Tidied up catching phrase, so it's always catched by const reference, 3) no d-pointer (there should be no cascade header inclusion) and reduced implementation to only what() method, 4) we use code from standard library, which implements what() method, so we have less to compile, 5) MyMoneyException constructor is inlined, but it should be short, because of the use of POD types only, 6) two defines to throw an exception (explanation below). mymoneyexception.h contains header for std::runtime_error and two defines for customizing exception messages. First define, MYMONEYEXCEPTION constructs the message roughly in the following way: 1) construct QString from __LINE__, which is int, 2) construct QString from __FILE__, which is const char *, 3) take exception message, only QStrings allowed, 4) construct QString from the three strings above, 5) construct const char * from QString, for which std::runtime_error has a constructor. As one can see, there is lot of effort to throw an exception, so there MYMONEYEXCEPTION_CSTRING has been introduced, to avoid all above mentioned memory allocations. Differential Revision: https://phabricator.kde.org/D12808 commit fc35ce3d7df5d6e0da57e19524f6d8ca41d1f212 Author: Łukasz Wojniłowicz Date: Sat May 12 15:55:22 2018 +0200 Format CSV plugin headers according to the KDE guidelines Purpose of this patch is to tidy up source code headers. Right now we've got three different types of headers (accountsviewproxymodel.cpp, payeeidentifier.cpp, kcurrecycalculator.cpp). This patch will standardize them to one according to https://community.kde.org/Policies/Licensing_Policy#GPL_Header Moreover, there are some names in the headers, which have not event touched the file, so it's false authorship. Those names has been removed. List of the names to remove has been taken from: 1) CVS logs (http://kmymoney2.cvs.sourceforge.net/), 2) git logs, 3) CVS mailing list (https://sourceforge.net/p/kmymoney2/mailman/kmymoney2-developer/) 4) CVS stats (http://kmymoney2.sourceforge.net/kmymoney2-stats/authors.html) Differential Revision: https://phabricator.kde.org/D12836 commit 7b7679912dfbafbd189680c4d32855c8c3c97fc1 Author: Thomas Baumgart Date: Fri May 18 21:28:21 2018 +0200 Fix compiler warnings commit d36a1ff0af77e9a76ba10731f23df98f21d9fc1f Author: Łukasz Wojniłowicz Date: Fri May 18 16:59:57 2018 +0200 Try to fix compilation on MacOS commit 236e3d3996aa73596291c0be87860d0d5980abb3 Author: Łukasz Wojniłowicz Date: Tue May 15 21:05:52 2018 +0200 Remove -Wl,--warn-common commit 919f24182eb0321bb97d0fb84e83dc605c2c410c Author: Łukasz Wojniłowicz Date: Tue May 15 20:21:34 2018 +0200 Try to fix compilation on MSVC MyMoneyAccount::payeeIdentifiersByType caused C2491 error on MSVC. Probably because its template has been defined in cpp file. It was the only one valid template and used in only one place, so it has been moved to sepaOnlineTransferImpl to bring sepa functionality to MS Windows. commit e3585022ae9d651d59374510bca2db8ee6b3f27c Author: Łukasz Wojniłowicz Date: Tue May 15 20:53:27 2018 +0200 Try to fix compilation on MacOS MacOS has linker not compatible with GNU linker, so flags aren't interchangeable. Man page for MacOS linker is here https://www.unix.com/man-page/osx/1/ld/ I'm setting these options blindly as temporarily I have no access to my own builds. commit 34b9b705eac17a43ced97082a1979b6b3903c182 Author: Thomas Baumgart Date: Tue May 15 14:43:32 2018 +0200 Fix another corner case with the new online balance marker commit 1ccc34df44e79b1712e6361ef201c74e065c9bb2 Author: Łukasz Wojniłowicz Date: Sun May 13 20:48:30 2018 +0200 Try to fix compilation on MacOS commit bd5d59937dc442bcbc8a5628e8e45dbc4f1515c2 Author: Łukasz Wojniłowicz Date: Sun May 13 18:53:41 2018 +0200 Try to fix compilation on MacOS and MS Windows commit c9caff4ca48a3a478ee6f97dff110fef6b989e15 Author: Thomas Baumgart Date: Sun May 13 18:25:42 2018 +0200 Correct display of online balance marker In some cases a false duplicate online balance marker was shown in the new ledger. commit 33f9e1f6ec9b69c20152175dac7e2362220a600d Author: Thomas Baumgart Date: Sun May 13 16:00:12 2018 +0200 Prevent edit via double-click for online transactions Don't start editing an online transaction in case the Edit button is disabled. This closes a backdoor. The only thing that is available at this point is the copy feature of an already sent transaction, but that is broken to some extent. commit f1942f1957f0748334a4592faa146cff8c0a864f Author: Thomas Baumgart Date: Sun May 13 12:35:50 2018 +0200 Fix setup for for multi profile build generators Summary: Fix concern raised in https://phabricator.kde.org/R261:d1ef13e4ab9e71df7b723b7c57ed4b3c736d89fd Test Plan: Compiled with DebugFull and Release Reviewers: christiand Reviewed By: christiand Differential Revision: https://phabricator.kde.org/D12844 commit 5b127f13b2e4a5b4b9d48d79a09b171620335958 Author: Łukasz Wojniłowicz Date: Sat May 12 18:03:11 2018 +0200 Fix database URL construction for MSVC Differential Revision: https://phabricator.kde.org/D12681 commit 326b896386f2c972aacfe5ffdbaf73c66bc51098 Author: Łukasz Wojniłowicz Date: Fri May 11 17:26:29 2018 +0200 Fix OFX statement importing This patch intends to fix a regression, which has been described in the following post https://mail.kde.org/pipermail/kmymoney-devel/2018-March/020669.html Differential Revision: https://phabricator.kde.org/D12829 commit 2cfedb101879f9655489162192ae3c7cf5f8d654 Author: Łukasz Wojniłowicz Date: Fri May 11 16:01:38 2018 +0200 Prevent crash in onlineJobAdministration::canSendCreditTransfer How to reproduce: 1) start kmymoney 2) go to outbox view 3) close kmymoney 4) crash onlineJobAdministration::canSendCreditTransfer needs MyMoneyStorageMgr which gets deleted just before outbox view is deleted which triggers onlineJobAdministration::canSendCreditTransfer. This patch moves removal of MyMoneyStorageMgr after removal of all plugins. commit 932193fced0babe62a26665c35b26b20fa93d685 Author: Łukasz Wojniłowicz Date: Fri May 11 05:59:29 2018 +0200 Fix compiler flags on FreeBSD and MacOS commit e4187499471867146abbd8f73a0734258835879b Author: Łukasz Wojniłowicz Date: Wed May 9 11:22:38 2018 +0200 Fix some warnings Differential Revision: https://phabricator.kde.org/D12782 commit 0fa6ef4fd3ea99998735d77d3f4c2274a40b80d8 Author: Marc Hübner Date: Thu May 10 17:57:37 2018 +0200 Export templates in MyMoneyAccount MSVC fails with a following error https://phabricator.kde.org/R261:44f846f13d0f7c7cca1178d56492471cb9f5092b#3629295. Let's see if this patch will help. commit b2ad662f308d4d284ed12213a32bfed7989d67bc Author: Łukasz Wojniłowicz Date: Tue May 8 10:35:20 2018 +0200 Reenable storing of payeeIdentifier in SQL storage commit 32a8fd984b17f0eefe660082f8484930d1b155d9 Author: Łukasz Wojniłowicz Date: Tue May 8 10:37:48 2018 +0200 Fix saving and opening of SQL storage commit f724738bf74178dc2602a3eade4b28fe99d218f1 Author: Christian Dávid Date: Sat Apr 7 23:25:36 2018 +0200 Minor code improvements Debug output improved, added usages of nullptr and shortened some code. commit 51ae6493947b62eb3a31570f76193233bc71e93f Author: Thomas Baumgart Date: Fri May 11 15:22:47 2018 +0200 Fix 'Schedule option "Do nothing" is confusing' BUG: 391925 commit e5198a902996b27bf9abde0ad24af82d55ab5dc1 Author: Luca Beltrame Date: Thu May 10 09:35:34 2018 +0200 Fix build with Qt 5.11 commit 38fb3b2105852c047a73bfbd0861618c6386560f Author: Łukasz Wojniłowicz Date: Mon May 7 08:05:34 2018 +0200 Add more compiler warnings Purpose of this patch is to enhance code quality. It also enhances readability of flags used for different compilers. Differential Revision: https://phabricator.kde.org/D12737 commit 9a4f7ab07154225754040aa148565253f2bcd74a Author: Thomas Baumgart Date: Sun May 6 11:56:07 2018 +0200 Keep context menu at cursor position The context menu of the online job view is shown in the top left corner of the screen instead close to the item in the list it is opened for. This change opens the context menu at the current cursor pos. commit fc31d5aa57aa7b55e3387ce7a1986f1d22148c90 Author: Łukasz Wojniłowicz Date: Sun May 6 09:16:58 2018 +0200 Compile onlineJobMessage only once commit a86fead27c16ca87b94e06cb09e00b1f7856e2fe Author: Łukasz Wojniłowicz Date: Sun May 6 07:22:35 2018 +0200 Fix some warnings on MSVC commit 3331d5a8dac5b5b7eb5b128ed230c03b640cb6b6 Author: Łukasz Wojniłowicz Date: Sun May 6 05:35:45 2018 +0200 Fix MSVC build, try 4 commit ddbba41483185058f2615b5eaa938259b38a3000 Author: Łukasz Wojniłowicz Date: Sat May 5 21:59:59 2018 +0200 Use Qt's d-pointer for AccountsProxyModel and its derivatives MSVC reports that "definition of dllimport static data member not allowed" in AccountsViewProxyModel and the only data member there is "m_visColumns", so let's try to put it behind d-pointer and see what happens. commit ec51c7bcb764e55d934b68c5875163ba580f36fb Author: Łukasz Wojniłowicz Date: Sat May 5 12:57:23 2018 +0200 Fix MSVC build, try 3 commit 25caf0e2707adfa8148cc3e2cd838c466e223133 Author: Łukasz Wojniłowicz Date: Sat May 5 12:42:01 2018 +0200 Fix MSVC build, try 2 commit 9cef60db5c9202f6b3a01642706dc98ceac76007 Author: Łukasz Wojniłowicz Date: Sat May 5 11:56:23 2018 +0200 Try to fix MSVC build commit 431c3fff99430af36d500f76a45a2b0c5e729a84 Author: Łukasz Wojniłowicz Date: Sat May 5 10:42:04 2018 +0200 Remove KMyMoneyApp variable from KMyMoneyView Purpose of this patch is to lessen dependency on big KMyMoneyApp. Differential Revision: https://phabricator.kde.org/D11858 commit 4683c69ce288e48919544dde89b18a2b028677a1 Author: Łukasz Wojniłowicz Date: Mon Apr 30 19:51:32 2018 +0200 Break scheduled transactions the other way MSVC reports warning if \u2028 is used. It treats it as literal character and not as LINE SEPARATOR. Let's try to trick it by breaking unicode character down to bytes. commit 32ba9cb7b4695e2c2b4e7ed3ef192c0b85f4d972 Author: Łukasz Wojniłowicz Date: Mon Apr 30 19:05:02 2018 +0200 Make icons visible on MacOS Craft on MacOS uses icons resource as in the case of MS Windows, so the outcome should be the same. This hasn't been tested though. commit 812a3b8cb7beb565d36181f0571cb5747e26a7ba Author: Łukasz Wojniłowicz Date: Wed May 2 20:57:47 2018 +0200 Pluginize KBudgetView commit 381eb02cd55fa4a9f3490ae12eb5ff54492edf5b Author: Łukasz Wojniłowicz Date: Sat Apr 28 19:16:46 2018 +0200 Pluginize KOnlineJobOutbox This patch makes online job outbox view optional instead of mandatory. User can switch on and off this view and have more space on views pane. Developers will benefit by saving on build time of this plugin. It compiles KMyMoneyAccountCombo and links to static models library just like QIF exporter does. Something has to be done with this, but for now switchable outbox is enough feature to be committed. Differential Revision: https://phabricator.kde.org/D11841 commit 19a83aeac925776df2c84bde9a3dd7d4e8a2ddfb Author: l10n daemon script Date: Wed May 2 06:15:44 2018 +0200 GIT_SILENT made messages (after extraction) commit 5498cb65bc595e82e2fe30b8d59af52748c789d6 Author: Thomas Baumgart Date: Sun Apr 29 15:47:31 2018 +0200 Get rid of deprecated warnings The clear button functionality is now part of QLineEdit so we might as well remove it here. commit 1c8a63c85e8d4280e78ab0cd245f6dae279e95ca Author: Thomas Baumgart Date: Sun Apr 29 14:29:56 2018 +0200 Fix working week Summary: There's a feature in scheduled transactions which allow them to move backwards/forwards in case a scheduled entry falls on a non-processing day, e.g. a weekend. However, I've noticed that that seems to have stopped working in 5.x/master. This change brings back this functionality. BUG: 393168 FIXED-IN: 5.0.2 Reviewers: #kmymoney, christiand, tbaumgart Reviewed By: #kmymoney, christiand, tbaumgart Subscribers: tbaumgart, christiand Tags: #kmymoney Differential Revision: https://phabricator.kde.org/D12412 (cherry picked from commit 983a33b786a20b503fb55a6411784ef64df5f895) commit 983a33b786a20b503fb55a6411784ef64df5f895 Author: Thomas Baumgart Date: Sun Apr 29 14:21:04 2018 +0200 Fix working week Summary: There's a feature in scheduled transactions which allow them to move backwards/forwards in case a scheduled entry falls on a non-processing day, e.g. a weekend. However, I've noticed that that seems to have stopped working in 5.x/master. This change brings back this functionality. BUG: 393168 Reviewers: #kmymoney, christiand, tbaumgart Reviewed By: #kmymoney, christiand, tbaumgart Subscribers: tbaumgart, christiand Tags: #kmymoney Differential Revision: https://phabricator.kde.org/D12412 commit 254c19105ca60e490ccdc786036bb1e3bf0ac21f Author: Thomas Baumgart Date: Sun Apr 29 14:06:24 2018 +0200 Don't wrap last reconciliation date on home page This change replaces the breakable space with its non-breakable version commit f621b760740aa72b056f98fe2aea20c3ed8980e1 Author: l10n daemon script Date: Mon Apr 23 05:26:06 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit c1032c7c2ee348ba2cec0d210c6cc7de5aa7d2ce Author: l10n daemon script Date: Mon Apr 23 03:30:42 2018 +0200 GIT_SILENT made messages (after extraction) commit 7a4278c3f21ab13ef2d0f572b19cda301c9d4140 Author: Łukasz Wojniłowicz Date: Sun Apr 22 21:21:14 2018 +0200 Use qAbs instead of std::abs It works on Linux but it failed on MacOS. commit 6f07bf71f5ff52a7483ddd5aace78a4648d20b1c Author: l10n daemon script Date: Wed Apr 18 06:34:00 2018 +0200 GIT_SILENT made messages (after extraction) commit e60ffdaf449afcabdbd49a0f6fab3dc99c3d6d21 Author: Thomas Baumgart Date: Sat Apr 14 08:43:43 2018 +0200 Improved some messages commit e3c2fdd5a074c775a57b510609b7b7fac1042d38 Author: l10n daemon script Date: Fri Apr 13 05:20:29 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 39bce7ad722e3bfa32708552db6b32232a8751ae Author: Łukasz Wojniłowicz Date: Thu Apr 12 19:01:27 2018 +0200 Find LibOFX on MacOS PKG_CHECK_MODULES finds the OFX library, but KMyMoney fails to compile with it. Luckily it works MS Windows way. commit 97983db03ae44ecd2e49a724937256af56425ee7 Author: Thomas Baumgart Date: Thu Apr 12 13:15:18 2018 +0200 Improve string handling commit f936d66f87b152a41467b0488d54974cb3fda89f Author: l10n daemon script Date: Mon Apr 9 05:17:23 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 756d07cc3fab408108062882265ede4dd02d082a Author: Thomas Baumgart Date: Fri Apr 6 16:07:22 2018 +0200 Use QStringLiteral where applicable commit 6b57e4fe3bd86457d7aed966e3f510e7cb27b13b Author: l10n daemon script Date: Fri Apr 6 05:23:13 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit f3e41d540e9714ec034d351294a3efa39914512d Author: l10n daemon script Date: Wed Apr 4 06:05:03 2018 +0200 GIT_SILENT made messages (after extraction) commit 54ff216113fcf1ed347a05e5972283d80e91ad77 Author: l10n daemon script Date: Wed Apr 4 05:18:46 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit f5b43bd5fd86f7edd0da6c238da0ccb6d7cfbd93 Author: l10n daemon script Date: Wed Apr 4 03:27:01 2018 +0200 GIT_SILENT made messages (after extraction) commit e3d2f1f51f0062d7ae989c5ba03d5d1d072ce4a6 Author: l10n daemon script Date: Tue Apr 3 05:28:07 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 4480920d5d8627384e5cf1a1396644191e732df5 Author: Thomas Baumgart Date: Mon Apr 2 10:39:08 2018 +0200 Keep the OFX importer object name as provider Using the new plugin structure there is no need to use a fixed name anymore. Use the objectName() instead and things match. BUG: 392603 (cherry picked from commit bd6c509f2b2bef5fed962e751d13e14c68190980) commit bd6c509f2b2bef5fed962e751d13e14c68190980 Author: Thomas Baumgart Date: Mon Apr 2 10:35:42 2018 +0200 Keep the OFX importer object name as provider Using the new plugin structure there is no need to use a fixed name anymore. Use the objectName() instead and things match. BUG: 392603 FIXED-IN: 5.0.2 commit 77fe1dba8e6b9aee9f4185e21302bef74312aecd Author: l10n daemon script Date: Mon Apr 2 05:12:58 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 08db0a88682568ea0bd9c80598d241141805b99b Author: l10n daemon script Date: Sun Apr 1 05:30:37 2018 +0200 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit f78218ff38ee7469f79f76fc3942baae5cc62cbb Author: Łukasz Wojniłowicz Date: Sat Mar 31 07:45:46 2018 +0200 Pluginize reports view This patch makes reports view optional instead of mandatory. User can switch on and off this view and have more space on views pane. Developers will benefit by saving on build time of this plugin. This patch introduces kmm_menus shared library for QActions to work seamlessly across plugin interface. It's worth considering merge with settings and icons in the future, as these libraries are often required together. Differential Revision: https://phabricator.kde.org/D11833 commit ad83acb7c9a972dfc84542de4751cf2d038f8780 Author: Łukasz Wojniłowicz Date: Fri Mar 30 12:52:05 2018 +0200 Coverity fixes Differential Revision: https://phabricator.kde.org/D11805 commit 00685e8aaec8b425baa5857e68f3681227b4e054 Author: Thomas Baumgart Date: Fri Mar 30 07:47:55 2018 +0200 Bumped version for next release commit 95c55340123950aa026ab495a79242e0a77cd32f Author: Thomas Baumgart Date: Fri Mar 30 07:45:37 2018 +0200 Use Qt's d-pointer implementation in AccountsModel Need for the change comes from bug #391251. It's more like a try and check, because I cannot reproduce bug from the report. Backport to 5.0 branch (based on cherry picked commit d442173234276a5fa1cc486182f1f314993533bb) commit d442173234276a5fa1cc486182f1f314993533bb Author: Łukasz Wojniłowicz Date: Fri Mar 23 17:14:38 2018 +0100 Use Qt's d-pointer implementation in AccountsModel Need for the change comes from bug #391251. It's more like a try and check, because I cannot reproduce bug from the report. commit b1dcf961c78859818369bcb331b726b1468608b4 Author: Łukasz Wojniłowicz Date: Tue Mar 20 18:41:21 2018 +0100 Redesign signals system for views Current system has many types of signals for views, which isn't plugin friendly. New system has only three signals and three corresponding methods for interacting with views: 1) selectByObject - for all signals that need MyMoneyObject only 2) selectByVariant - for all non-standard signals, which cannot be easily converted to MyMoneyObject 3) customActionRequested - for signaling some event, e.g. printing New system, besides object, requires to specify intent of the signal. This comes in handy at synchronizing accounts between investment and ledgers view. There is no more setDefaultFocus(), refresh() and updateActions(const MyMoneyObject&) because they were be replaced by above mentioned signals/slots and the interaction with views is thus more coherent. Differential Revision: https://phabricator.kde.org/D11720 commit d9e9595a51774b17e93f9a39160d6eb880a757f3 Author: Thomas Baumgart Date: Mon Mar 26 22:45:01 2018 +0200 Fix krazy control to cover complete files commit 5cb7e8cb0f5dfce08aa81b44f888a15ab6c48456 Author: Thomas Baumgart Date: Mon Mar 26 21:12:36 2018 +0200 Improve chiptan dialog Set input focus into TAN field Stretch the flicker field with higher precedence Resize the declarative view with the QML object commit 3a252e8659bfb1480b1050c6b4136f93e37b3c81 Author: Thomas Baumgart Date: Mon Mar 26 21:11:18 2018 +0200 Fix spelling and trailing blanks commit dae9b9045a5256dcca081ff88fc9837ebe48fccd Author: Christian Dávid Date: Mon Mar 26 20:23:38 2018 +0200 Coding Style: Use CMake commands lower case only Replaced CMAKE_DEPENDENT_OPTION by lower case version. commit a0107c00fbc124ec2f82c65b5625b52b4f57bc9f Author: Thomas Baumgart Date: Sun Mar 25 19:43:11 2018 +0200 Use KDE_INSTALL_DOCBUNDLEDIR instead of HTML_INSTALL_DIR KDE_INSTALL_DOCBUNDLEDIR is the "new" value, HTML_INSTALL_DIR is the deprecated value commit 588cceb7e069e66c82e8b1abf672f4b7019fef96 Author: Thomas Baumgart Date: Sun Mar 25 13:32:11 2018 +0200 Prevent uninitialized members Fix problem reported by coverty scan commit f1cb89dcf279c8dacda5034e06b4754b7e59f638 Author: Thomas Baumgart Date: Sun Mar 25 12:40:09 2018 +0200 Resolve krazy code analysis warning commit db0c4c20f7628953d4c8b673319fd740f29b7c25 Author: Thomas Baumgart Date: Sun Mar 25 11:14:19 2018 +0200 Extract IBAN, BIC and currency from MyMoneyAccount object Extracting IBAN and BIC from the MyMoneyAccount object was turned off since it causes trouble on MSVC but it works OK on Linux. So I keep it off for Q_OS_WIN only. Also, the currency can be extracted from the MyMoneyAccount object in case it is known. Otherwise, the base currency will be used. commit a30b5d61dea1ddbfe0a6e1076581a060413e98f7 Author: Thomas Baumgart Date: Sun Mar 25 11:11:12 2018 +0200 Fix order of member initialization commit 108de7e0d0eac5a14b7bf3d545705c03df730272 Author: Thomas Baumgart Date: Sun Mar 25 11:10:26 2018 +0200 Update list of SEPA participants commit 88e9ab54239ea63efca56ee2d3718019c50c2cae Author: Thomas Baumgart Date: Sat Mar 24 22:59:06 2018 +0100 Show values right aligned in online job view commit 16d1d3a26de7a8655ca5729058ca9c0795b9d448 Author: Thomas Baumgart Date: Sat Mar 24 22:58:44 2018 +0100 Fix online credit transfer creation The online credit transfer creation was broken after a bunch of changes and the port to KF5. This commit brings the functionality back to the user. commit a6ce0a52094043d2cc9cc5abee93ed6371065ecc Author: Łukasz Wojniłowicz Date: Sat Mar 24 08:12:07 2018 +0100 Use CMake's FeatureSummary Purpose of this patch is to replace handcrafted KMyMoney build configuration summary with the standard CMake's FeatureSummary macro. The advantage is simplified and standard looking main CMakeLists.txt file e.g. finding and reporting libical has been reduced from 15 to 3 lines. Differential Revision: https://phabricator.kde.org/D11640 commit fd5405aefaf849827829ec43d6241134b875429f Author: Łukasz Wojniłowicz Date: Tue Mar 20 20:43:42 2018 +0100 Coverity fixes Differential Revision: https://phabricator.kde.org/D11618 commit 5de8e6866edadfd052f4a3276b614751b96e34bd Author: Thomas Baumgart Date: Sat Mar 24 13:38:39 2018 +0100 No need to install plugin twice The installation happens apparently already through kcoreaddons_add_plugin commit 3db841bcd65274f12eaf379a09425bf3bd8e336d Author: Thomas Baumgart Date: Wed Mar 21 21:34:08 2018 +0100 Resolve some coverty scan problems commit b4dea47448e72e1b684ae5c359a61d7eed349b90 Author: Thomas Baumgart Date: Wed Mar 21 21:33:32 2018 +0100 Removed unused code commit e0cc92082647d739e34b5895811c9a917979b8ef Author: Łukasz Wojniłowicz Date: Sun Mar 18 10:23:13 2018 +0100 Refer to views by KMyMoneyViewBase I want to refer to the views in a generic way in order to be able to manage them in a simple way i.e. through viewFrames and viewBases. It's not possible fully right now, so many static_cast appears, but they will disappear with an advent of reworked signals framework. Differential Revision: https://phabricator.kde.org/D11464 commit 07d031bc95b5a6adfb11ca92865435b09a50acd2 Author: Thomas Baumgart Date: Tue Mar 20 20:11:45 2018 +0100 Add color coding of pos/neg amounts for 'posted value' column Summary: add color coding of pos/neg amounts for 'posted value' column Original implementation by Marc Hüber Reviewers: #kmymoney, tbaumgart Reviewed By: #kmymoney, tbaumgart Subscribers: tbaumgart, wojnilowicz Tags: #kmymoney Differential Revision: https://phabricator.kde.org/D11406 commit 1bd6165da5ed15e20de2d6bea617a353f735e4e9 Merge: b16c8f25 8b086cf9 Author: Thomas Baumgart Date: Tue Mar 20 20:00:11 2018 +0100 Merge remote-tracking branch 'origin/5.0' commit 8b086cf921879770971e9331f005339bfacdc84c Author: Andreas Sturmlechner Date: Mon Mar 19 17:51:27 2018 +0100 Fix weboob option in custom configure summary Reviewers: #kmymoney, wojnilowicz Reviewed By: #kmymoney, wojnilowicz Differential Revision: https://phabricator.kde.org/D11494 commit b16c8f25cb0257c2d9054b7e0976a4666df835e0 Author: Łukasz Wojniłowicz Date: Sun Mar 18 11:39:25 2018 +0100 Fix the build, try 3 commit 416638f6f952d936cc6ee2ec36a96b8a846e58fd Author: Łukasz Wojniłowicz Date: Sun Mar 18 11:33:15 2018 +0100 Fix the build, try 2 commit 6c6529096adcaecfd9267a28c6179e8a0abcd987 Author: Łukasz Wojniłowicz Date: Sun Mar 18 11:15:27 2018 +0100 Try to fix the build commit ea1fca56fb25955f7fa37de2fc11b3b6358f79af Author: Łukasz Wojniłowicz Date: Sun Mar 18 10:41:25 2018 +0100 Include clocale instead of locale.h Building KMyMoney on FreeBSD fails here https://build.kde.org/job/Extragear%20kmymoney%20kf5-qt5%20FreeBSDQt5.9/ and this patch is intended to fix that. According to http://en.cppreference.com/w/cpp/locale/localeconv the function std::localeconv() can be used if "clocale" is included, but in our case "locale.h" is included, which coresponds to plain C language. I assume that's causing problem on FreeBSD. I didn't test it in real environment. Differential Revision: https://phabricator.kde.org/D11408 commit 7bac65b4e7dbf90f4705df2991a8330b654c1444 Author: Łukasz Wojniłowicz Date: Sun Mar 18 10:32:48 2018 +0100 Use kcoreaddons_add_plugin This patch steals idea from D9710. The difference in regard to the other patch is: 1) right .json file is used for every plugin, 2) no redundant paths are added in code (only build system is modified), 3) no two different paths for installing plugins, 4) all plugins get stored in bin directory after build. More about it can be red on https://github.com/KDE/kcoreaddons/blob/master/KF5CoreAddonsMacros.cmake Loading plugins without plugins path set is not working for me, but I think it should work for someone according to http://doc.qt.io/qt-5/qcoreapplication.html#libraryPaths Differential Revision: https://phabricator.kde.org/D11160 commit fa926129fea7432ec7eac0f0814615be5a5a5eaf Author: Łukasz Wojniłowicz Date: Fri Mar 16 21:13:55 2018 +0100 Fix some MSBuild warnings commit 56f95eff8089a1ef3030ba9c467e6b50d730e54d Author: Łukasz Wojniłowicz Date: Fri Mar 16 20:40:40 2018 +0100 Move online actions to KAccountsView Switching actions for online accounts is already handled in KAccountsView, so handle the actions there as well. This allows greater encapsulation, as KMyMoneyApp doesn't have to know which account is currently selected and KMyMoneyView doesn't need to call KMyMoneyApp. Differential Revision: https://phabricator.kde.org/D11407 commit 1deb5cb0dc4c92403d3f1b4444abba8c8173520c Author: Łukasz Wojniłowicz Date: Wed Mar 7 19:18:59 2018 +0100 Disable C compiler KMyMoney is solely a C++ project, so disable a C compiler explicitly. Differential Revision: https://phabricator.kde.org/D11141 commit 5c47785ededbb37f752ed161dfea29aea1404f38 Author: Thomas Baumgart Date: Sun Mar 18 10:28:46 2018 +0100 Try to fix build for FreeBSD commit a650517e49b97550819d2812afe9b42fcab93646 Author: l10n daemon script Date: Thu Mar 15 05:18:26 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 43c263b3415144fbfdb12b468172d3ac74043594 Author: Thomas Baumgart Date: Mon Mar 12 22:17:05 2018 +0100 Remove windows specific reference commit 2bf4cd1e71992b7f7ead67e9811c766a8d0a55aa Author: Marc Hübner Date: Mon Mar 12 08:57:23 2018 +0100 Fix missing semicolon that breaks craft/windows build. Summary: Fix broken craft build due to syntax error. Test Plan: built on windows with craft. Reviewers: #kmymoney, tbaumgart Reviewed By: #kmymoney, tbaumgart Subscribers: #kmymoney Tags: #kmymoney Differential Revision: https://phabricator.kde.org/D11249 commit 68ac2fe9a737dc58e4bfc81e43df7f744ccb0a90 Author: Marc Hübner Date: Sat Mar 10 14:35:18 2018 +0100 display reconciliation date on homepage Summary: this patch adds the possibility to have the corrresponding reconciliation date displayed alongside each account on the home page. This is optional and can be enabled or disabled via a setting in the config dialog. Reviewers: #kmymoney, tbaumgart, wojnilowicz Reviewed By: #kmymoney, tbaumgart, wojnilowicz Subscribers: wojnilowicz, ostroffjh, tbaumgart Tags: #kmymoney Differential Revision: https://phabricator.kde.org/D10001 commit f8fb35d1585b9d5375f7de1ccbe2bc5238a2bbbb Author: l10n daemon script Date: Mon Mar 12 03:14:12 2018 +0100 GIT_SILENT made messages (after extraction) commit d5d71027cabe9950d759b660239075bf0aa45ccc Author: l10n daemon script Date: Sun Mar 11 05:21:12 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit afcdb30a02ca70b17db8249956113fa6e9742e91 Author: Łukasz Wojniłowicz Date: Thu Mar 1 19:38:17 2018 +0100 Introduce KTransactionFilter Purpose of this patch is to make KReportConfigurationFilterDlg independent from KFindTransactionDlg. It's done by introducing KTransactionFilter which doesn't depend on KMyMoneyRegister and is a kind of frontend for setting MyMoneyTransactionFilter. This approach will allow us to make plugin out of KReportsView and it makes interface tidier as presented on the image below. Differential Revision: https://phabricator.kde.org/D11014 commit 2a96f9478dd175a2d241f4cba3a0feee4f99ac04 Author: l10n daemon script Date: Tue Mar 6 05:20:51 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit ed01b4c32e260bad418a9c64fcd29765110b2b6d Author: l10n daemon script Date: Tue Mar 6 03:17:46 2018 +0100 GIT_SILENT made messages (after extraction) commit 1c3dfb32f903fad1eed4322b479ac5adfadd15e0 Author: Thomas Baumgart Date: Sun Mar 4 16:01:58 2018 +0100 Make sure that investment and ledger view are synced This amends the last commit to completely bring back the old functionality. commit c6dde9ffbf139a0c01b80abcf1e7bbae5b63c612 Author: Thomas Baumgart Date: Mon Mar 5 07:39:20 2018 +0100 Fix save as when encryption is turned on Improve commit 03831143604 which prevents saving under a different name when the encryption is globally turned on. (cherry picked from commit de1642b477a44fedded12fe5ea55fbe37974e29d) commit 7912497cc7a359342376aa7249c6b94f48b40939 Author: l10n daemon script Date: Mon Mar 5 03:16:27 2018 +0100 GIT_SILENT made messages (after extraction) commit 757c7cbe64e0a82794677321f3ce6c1e795185c5 Author: Łukasz Wojniłowicz Date: Mon Feb 26 17:44:59 2018 +0100 Remember last selected account in ledgers BUG:390406 FIXED-IN:5.0.1 commit 3fc2c1f422c6ea415bdbd65703a4835504ccb4c6 Author: Łukasz Wojniłowicz Date: Sun Feb 25 15:10:36 2018 +0100 Register KMyMoney with process ID BUG:350850 FIXED-IN:5.0.1 commit 10a45740e86764efc2f70b5d646f04a66330e825 Author: Łukasz Wojniłowicz Date: Fri Feb 23 18:18:38 2018 +0100 Move opening files to KMyMoneyApp In my opinion opening file has little to do with views, so I moved it to KMyMoneyApp. KMyMoneyApp in many places already called KMyMoneyView in this regard, so the move around seems like a good choice. It also serves as a one step forward in making KMyMoneyView independent of KMyMoneyApp. The next step would be to reduce a rather long code to open a simple file. Differential Revision: https://phabricator.kde.org/D10790 commit dbb7bebed66aa0be77214179c65add0197a48f77 Merge: 2f4a8ff9 b93a5d0d Author: Thomas Baumgart Date: Sun Mar 4 12:46:36 2018 +0100 Merge branch '5.0' commit 2f4a8ff957f807bc636e84d088960c06aeafde8c Author: l10n daemon script Date: Sun Mar 4 05:16:47 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 945738582ade35aa2b68be61dd133ff5661029bb Author: l10n daemon script Date: Sun Mar 4 03:17:58 2018 +0100 GIT_SILENT made messages (after extraction) commit 6375a730aea16afdc377424f3619562251846bb4 Author: Thomas Baumgart Date: Sat Mar 3 12:56:56 2018 +0100 Catch exception returned by accountByName() BUG: 391305 commit b3ea7ca35b92ee46140c40bca10451940e124b56 Author: Thomas Baumgart Date: Fri Mar 2 09:57:14 2018 +0100 Fix krazy warnings commit f068f8a686c656f7f9e4410089a77e050d5bf06c Author: Thomas Baumgart Date: Fri Mar 2 09:13:34 2018 +0100 Tried to fix an Krazy warning The text is identical, the only difference is that TABs are used for whitespace. I replaced them with blanks. Maybe, that helps to resolve the problem. commit 6676cec5d1ad492141db933b70098e548fa8d0ed Author: l10n daemon script Date: Wed Feb 28 03:17:44 2018 +0100 GIT_SILENT made messages (after extraction) commit da3f23977f72f7644fd4834c37a218778bfcd1bb Merge: 939bc9b1 bf29a136 Author: Thomas Baumgart Date: Tue Feb 27 20:43:21 2018 +0100 Merge branch '5.0' commit 939bc9b1d59a5e44d4c00699b2e00af3379383c6 Author: Thomas Baumgart Date: Mon Feb 26 21:54:09 2018 +0100 Make sure account object has correct fraction information Retrieving a list of all accounts could leave the account objects returned without fraction information. This change makes sure that all accounts have a correct value for the fraction (which is based on account type and currency) BUG: 391068 commit 6b4da5ac620cc3199404191f686b9bc1e2429140 Author: l10n daemon script Date: Sun Feb 25 05:26:13 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit ef461c9fff14728ffea6826a16fb129b3e63f45e Author: l10n daemon script Date: Sun Feb 25 03:17:59 2018 +0100 GIT_SILENT made messages (after extraction) commit cff068898c03ea36a7e7488f09edb551e459d9f6 Author: Thomas Baumgart Date: Sat Feb 24 18:02:55 2018 +0100 Fix comments commit 6e2321172a285f686e7d795577fce23702bfc672 Author: Thomas Baumgart Date: Sat Feb 24 17:55:26 2018 +0100 Fix security retrieval from engine The call to MyMoneyFile::currency() not only returns currencies but also securities. This was broken due to a recent change. BUG: 390979 commit 0b3d53efa2ed78663d8fbce40ad4459b94219a32 Author: Thomas Baumgart Date: Sat Feb 24 17:53:55 2018 +0100 Added testcases to check security/currency retrieval commit d1ef13e4ab9e71df7b723b7c57ed4b3c736d89fd Author: Thomas Baumgart Date: Sat Feb 24 12:58:04 2018 +0100 Set necessary flag for debug builds commit 3acf35702f801bb67d5445bf09387e0dd1676de1 Author: Thomas Baumgart Date: Sat Feb 24 12:57:36 2018 +0100 Export more symbols commit 9d616136e123698a409d42b860a8786d5ed4bf08 Author: Łukasz Wojniłowicz Date: Wed Feb 21 19:22:31 2018 +0100 Make compilation work on MinGW Differential Revision: https://phabricator.kde.org/D10751 commit 85903f6520eb48e545c60e7e75661f3c962061c1 Author: Łukasz Wojniłowicz Date: Wed Feb 21 16:42:52 2018 +0100 Handle scheduled transactions in ledgers BUG:390834 FIXED-IN:5.0.1 Differential Revision: https://phabricator.kde.org/D10720 commit 13afc0cd7f2b761512d3a35e7545e16d5307cef9 Author: Łukasz Wojniłowicz Date: Thu Feb 22 17:04:09 2018 +0100 Break scheduled transactions string commit 1db9b53816604d44648a4c7e7832e19af71ac630 Author: l10n daemon script Date: Fri Feb 23 05:18:34 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 7150b4a58e788913d3d6e3ca1b78dd242aa27a1b Author: Łukasz Wojniłowicz Date: Sun Jan 21 09:27:05 2018 +0100 Remove MyMoneyObjectContainer MyMoneyObjectContainer served as double cache presumably for DB storage. For XML storage I see it as redundant, because it has its own cache and after latest changes in KMM it's also redundant for DB storage. Methods in MyMoneyObjectContainer returned its values as dereferenced pointers thus making it difficult to use compiler optimizations. Committing transactions to MyMoneyObjectContainer consisted of clearing and refilling whole cache, which isn't very efficient. Despite observed inefficiencies and removal of MyMoneyObjectContainer, I had not experienced any speed up. Differential Revision: https://phabricator.kde.org/D10637 commit 1aeea90b8ecb629c460dbc93f1e798e140d9834a Author: Christophe Giboudeaux Date: Wed Feb 21 12:26:29 2018 +0100 Fix build with CMake 3.1. GREATER_EQUAL was introduced in CMake 3.7. commit 06efb6eb1894a6cf9a6d37ac22128c7936159353 Author: l10n daemon script Date: Wed Feb 21 03:19:02 2018 +0100 GIT_SILENT made messages (after extraction) commit 93d27eb1e061a71a82402327009bbc90d4cd40e4 Author: Łukasz Wojniłowicz Date: Tue Feb 20 19:21:38 2018 +0100 Restrict new investment creation Previous code allowed creation of new stock for every account, which is not correct, as only investments account should be allowed. commit 15a24ce4e2bed0993e8b14fdd8c49ca87d155380 Author: Łukasz Wojniłowicz Date: Tue Feb 20 18:08:22 2018 +0100 Break scheduled transactions string There is a bug in static int layoutText(QTextLayout *layout, int maxWidth) from kpageview_p.cpp from kwidgetsaddons. The method doesn't break strings that are too long. This patch workarounds this by using LINE SEPARATOR character which is accepted by QTextLayout::createLine(). commit 3f08c3e3cb1c031275d9d1e1b411766e028c9bf0 Author: Łukasz Wojniłowicz Date: Tue Feb 20 17:41:13 2018 +0100 Keep up with register changes BUG:390593 FIXED-IN:5.0.1 commit 5d135c93c6980ea42017822aa1ff6903ef9c19fe Author: l10n daemon script Date: Tue Feb 20 04:57:49 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 0ada75631c6f5ce3d0ac316a445736f6d8df421f Author: l10n daemon script Date: Tue Feb 20 03:15:13 2018 +0100 GIT_SILENT made messages (after extraction) commit 6d808aa741259a6e00931bc4e504eb5307e32349 Author: Thomas Baumgart Date: Mon Feb 19 16:13:09 2018 +0100 Remove generated files These two files are generated by the 5.0 branch and are in the way in case you switch to master. Eventually, these lines can be removed again. commit 665345b6fdad5741e31adebae281bff9992ad796 Author: Thomas Baumgart Date: Mon Feb 19 16:11:52 2018 +0100 Fix include filename Leftover from commit e2448f62ed3da50010ae7a987a33873e0d44ca05 "Moved settings into their own library" commit b863c70bc9808ff5a49c3e155bc03308f17dfbce Author: l10n daemon script Date: Mon Feb 19 04:59:17 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 9477a5e5d0b27be02a1b5529c844082eed079d83 Author: l10n daemon script Date: Mon Feb 19 03:09:42 2018 +0100 GIT_SILENT made messages (after extraction) commit e2448f62ed3da50010ae7a987a33873e0d44ca05 Author: Thomas Baumgart Date: Sun Jan 28 16:24:12 2018 +0100 Moved settings into their own library Summary: Besides the move which really allows to have singleton throughout all shared objects and libraries of the application, I moved all additional settings function into the KMyMoneySettings object. This allows to remove the KMyMoneyGlobalSettings class completely. Compiling this in an existing build directory may cause trouble as some old generated files are left behind and might be used instead of new ones. You have been warned. Reviewers: wojnilowicz Differential Revision: https://phabricator.kde.org/D10161 commit 0c38ba95ad62aa26595aacb75a7276b475c492e8 Merge: c94c502b a01072c8 Author: Thomas Baumgart Date: Sun Feb 18 16:56:57 2018 +0100 Merge branch '5.0' commit c94c502b60f0df7f72541023955c0eb0bc3bb109 Author: Łukasz Wojniłowicz Date: Fri Jan 19 22:18:40 2018 +0100 Pluginize forecast view This patch makes forecast view optional instead of mandatory. User can switch on and off this view and have more space on views pane. Developers will benefit by saving on build time of this plugin. Pluginization is not yet perfect, but it will be polished with time. Differential Revision: https://phabricator.kde.org/D10428 commit 5adcba382751cc6c5b68c26c6a4196d49eac8654 Author: Łukasz Wojniłowicz Date: Fri Feb 9 15:12:21 2018 +0100 Pluginize SQL storage This patch makes database support in KMyMoney optional instead of mandatory. I believe most users use XML storage, so they could switch off SQL storage to save startup time and memory. Developers will benefit too, because they can switch off building of this plugin and save compilation time. Following safty checks were implemented: 1) user tries to open database with SQL storage plugin switched off, 2) user opens database and switches SQL storage plugin off and tries to save his storage I think that in future we could lower our core dependencies by droping off Qt5SQL. I also think, that we could switch between XML and SQL on the fly. Differential Revision: https://phabricator.kde.org/D10406 commit 6126755785cdcbad3f03245b78d90ecad4ebd61c Author: Thomas Baumgart Date: Fri Feb 9 20:07:16 2018 +0100 Removed duplicate class reference commit dcc80eb5a268e518e589bd242feaa246b4451f05 Author: Łukasz Wojniłowicz Date: Thu Feb 8 16:32:45 2018 +0100 Introduce MyMoneyStorageMgr This patch introduces MyMoneyStorageMgr class to avoid needless duplication of virtual methods in IMyMoneyStorage and IMyMoneySerialize and juggling between those two interfaces. It's a cornerstone for getting rid of MyMoneyObjectContainer as universal cache. Its code consists in big part from well proven MyMoneySeqAccessMgr and lends its capabilities to MyMoneyDatabaseMgr. Therefore databases now work just like xml file, i.e. read to cache, make all operations on cache and save to the file at the end of program. This brings us speed and unified code path. MyMoneyDatabaseMgr looked like duplicate code and had a little bit different logic in two places, which shouldn't happen. That's why tests had to be heavily modified and now are probably duplicate of MyMoneySeqAccessMgr test. If a database should be connected in real-time to KMyMoney then it's not possible at the moment and for sure shouldn't be solved as it was solved before. Differential Revision: https://phabricator.kde.org/D9869 commit 08ee6d11f4acf1564f4ad67ab4c80d188ec4e64a Merge: 444a23b7 16eb1fea Author: Thomas Baumgart Date: Thu Feb 8 21:09:27 2018 +0100 Merge branch '5.0' commit 444a23b7f30beffa67f337f46f0af950ceb53f3a Author: Łukasz Wojniłowicz Date: Wed Jan 10 18:54:29 2018 +0100 Optimize MyMoneyTransactionFilter for speed Opening home page on startup with big file (mine = 6 MB) takes lots of computational resources and with it time. This patch reduces need for that resources by 70 % in my test scenario in debug mode. This was possible after removing bottleneck that has been identified to be in MyMoneyTransactionFilter and the main cause was copying of MyMoneySplit objects. Instead of filling matchingSplits list in MyMoneyTransactionFilter right from the start and then removing unneeded ones, no split is added or it is added if it qualifies. Changes: 1) "container.isEmpty()" instead of "container.count > 0", as it's faster, 2) QVector instead QList for MyMoneySplit, as it's faster, 3) constify containers before for-range-loop, as it avoids costly detaches, 4) reduce unneeded ifs-trees, 5) replace QMutableListIterator with faster for-range-loop, 6) use QStringLiteral instead of const char* for split actions, to avoid costly memory allocations, 7) use QHash::contains instead of QHash::find for readability, 8) remove m_matchingSplits variable in favor of local ones, as it was short lived anyway, 9) new hackish m_matchOnly variable, to not fill matchingSplits list if we don't need it. Differential Revision: https://phabricator.kde.org/D9856 commit 0aee0c2e9579a692f20f008525979f0623ffd22f Author: Łukasz Wojniłowicz Date: Thu Feb 8 15:56:51 2018 +0100 Port Weboob to KF5 Kross doesn't want to run python scripts anymore, so Weboob plugin is dead. This patch makes it alive again. Changes: 1) no KF5::Kross dependency, as it is deprecated, 2) new Python2 dependency, as it's all we need to run weboob, 3) if no weboob is installed then plugin won't be compiled neither, 4) renamed weboob.py to kmymoneyweboob.py and put it in kmymoney/weboob directory to avoid name clashes, 5) renamed class names to better represent what they are for, 6) introduced little exception handling from python scripts and informational dialogs for that, 7) made single private class out of two in mapaccount, it is mystery why two of them were needed before, 8) avoided crashes/never ending progress bars if no weboob backends/accounts were loaded. Differential Revision: https://phabricator.kde.org/D9855 commit 08a626d7acf361def6858600803d1115fb950765 Author: Thomas Baumgart Date: Wed Feb 7 22:14:51 2018 +0100 Fix previous merge commit 90b53ea25856a1501f196bdbfcbb5acd224ee051 Merge: 09ffa40a 493a5765 Author: Thomas Baumgart Date: Wed Feb 7 21:30:58 2018 +0100 Merge branch '5.0' commit 09ffa40aa03859db42fd9ffe28f5eceb72c99267 Author: Christian Dávid Date: Sun Feb 4 15:36:52 2018 +0100 Silence CMake warning about policy CMP0071 Summary: This policy was introduced in CMake 3.10 and will annoy users until we set that CMake version as minimum. Probably we do not require this feature, yet. It is only set to old, to prevent accidential use of the new behavour. If the new behaviour becomes important, cmake_minimum_required has to be set to "3.10". Test Plan: Run `cmake .` Reviewers: #kmymoney, wojnilowicz, tbaumgart Reviewed By: #kmymoney, wojnilowicz, tbaumgart Subscribers: tbaumgart Differential Revision: https://phabricator.kde.org/D10162 commit 50b95a558e5b942add999b351d1e387940aace44 Author: l10n daemon script Date: Fri Feb 2 03:21:14 2018 +0100 GIT_SILENT made messages (after extraction) commit 1ca1072eec7472fbb6986ce91da000bc70a3c22a Author: Christian Dávid Date: Tue Jan 30 19:59:28 2018 +0100 Fixed some krazy warnings commit d87fd51e8ff490661eb7d57517bea2cfb3d6bd43 Author: l10n daemon script Date: Sun Jan 14 04:49:17 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit d6ddfd1102b4323fad8986a582e477c100364632 Author: l10n daemon script Date: Thu Jan 11 04:49:11 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit c7036d1eca3660e57ea00d9c54b925da1dcea754 Author: Christian Dávid Date: Tue Jan 9 21:58:16 2018 +0100 Extended timeout in reports-chart test On build.kde.org this test is unstabel - this could be a timeout issue which should be fixed with this commit. commit da3d6886a5bc0855b7f879ff9717114378dfab01 Author: l10n daemon script Date: Tue Jan 9 04:59:36 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 16e9a96c89b6505d0fc1f98446c8d80fdd83dde4 Author: l10n daemon script Date: Mon Jan 8 04:46:46 2018 +0100 SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop" commit 0f9b4f8b927679339de77d447d98b168363da00b Author: Łukasz Wojniłowicz Date: Sun Jan 7 17:06:54 2018 +0100 Specify the config file before construction time It seems that KMyMoneySettings aren't as shared as I thought. It seems that call to KMyMoneySettings in every translational unit uses different instance. Remaining at old code would require to create instance of config file in every translational unit in which KMyMoneySettings is used and not only in main function. That misses the point, so config filename is hardcoded as before in kcfg file. BUG:388640 FIXED-IN:5.0 commit 6d07feae1446527b0088d93ad37c5e72314a49ad Author: Thomas Baumgart Date: Sun Jan 7 10:19:19 2018 +0100 Bumped version number